Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2306)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

Issue 12253022: Manifest handler for all keys background-related. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc
index 14384f8cd1ed4a017a23dba9dae52df6c7736102..39d65eb85b2e525a7e14f5363fdafe98c9048a9a 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc
@@ -2,17 +2,30 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
-
+#include "chrome/common/extensions/background_info.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
#include "testing/gtest/include/gtest/gtest.h"
using extensions::Extension;
namespace errors = extension_manifest_errors;
-TEST_F(ExtensionManifestTest, OfflineEnabled) {
+namespace extensions {
+
+class ExtensionManifestOfflineEnabledTest : public ExtensionManifestTest {
+ virtual void SetUp() OVERRIDE {
+ ExtensionManifestTest::SetUp();
+ std::vector<std::string> background_keys(BackgroundManifestHandler::keys());
+ linked_ptr<BackgroundManifestHandler> background_handler(
+ new BackgroundManifestHandler);
+ for (size_t i = 0; i < background_keys.size(); ++i)
+ ManifestHandler::Register(background_keys[i], background_handler);
+ }
+};
+
+TEST_F(ExtensionManifestOfflineEnabledTest, OfflineEnabled) {
LoadAndExpectError("offline_enabled_invalid.json",
errors::kInvalidOfflineEnabled);
scoped_refptr<Extension> extension_0(
@@ -34,3 +47,5 @@ TEST_F(ExtensionManifestTest, OfflineEnabled) {
LoadAndExpectSuccess("offline_default_platform_app.json"));
EXPECT_TRUE(extension_5->offline_enabled());
}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698