Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 12253022: Manifest handler for all keys background-related. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index 7ee4eb8c3347acd92b031992dbc37f162f0bd7c4..eeba0265c6e6eba9c274f7399629df4a56cf04f7 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -27,6 +27,7 @@
#include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
#include "chrome/browser/view_type_utils.h"
#include "chrome/common/extensions/api/developer_private.h"
+#include "chrome/common/extensions/background_info.h"
#include "chrome/common/extensions/extension_icon_set.h"
#include "chrome/common/extensions/extension_resource.h"
#include "chrome/common/extensions/manifest_url_handler.h"
@@ -288,10 +289,11 @@ ItemInspectViewList DeveloperPrivateGetItemsInfoFunction::
GetShellWindowPagesForExtensionProfile(extension, &result);
// Include a link to start the lazy background page, if applicable.
- if (extension->has_lazy_background_page() && extension_is_enabled &&
+ if (BackgroundInfo::HasLazyBackgroundPage(extension) &&
+ extension_is_enabled &&
!process_manager->GetBackgroundHostForExtension(extension->id())) {
- result.push_back(
- constructInspectView(extension->GetBackgroundURL(), -1, -1, false));
+ result.push_back(constructInspectView(
+ BackgroundInfo::GetBackgroundURL(extension), -1, -1, false));
}
ExtensionService* service = profile()->GetExtensionService();
@@ -305,10 +307,11 @@ ItemInspectViewList DeveloperPrivateGetItemsInfoFunction::
process_manager->GetRenderViewHostsForExtension(extension->id()),
&result);
- if (extension->has_lazy_background_page() && extension_is_enabled &&
+ if (BackgroundInfo::HasLazyBackgroundPage(extension) &&
+ extension_is_enabled &&
!process_manager->GetBackgroundHostForExtension(extension->id())) {
- result.push_back(
- constructInspectView(extension->GetBackgroundURL(), -1, -1, false));
+ result.push_back(constructInspectView(
+ BackgroundInfo::GetBackgroundURL(extension), -1, -1, false));
}
}

Powered by Google App Engine
This is Rietveld 408576698