Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

Issue 12253022: Manifest handler for all keys background-related. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_manifest_constants.h" 5 #include "chrome/common/extensions/extension_manifest_constants.h"
6 #include "chrome/common/extensions/manifest_handler.h"
7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 6 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
8 #include "chrome/common/extensions/manifest_url_handler.h" 7 #include "chrome/common/extensions/manifest_url_handler.h"
9 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
10 9
11 namespace errors = extension_manifest_errors; 10 namespace errors = extension_manifest_errors;
12 11
13 class OptionsPageManifestTest : public ExtensionManifestTest { 12 class OptionsPageManifestTest : public ExtensionManifestTest {
14 virtual void SetUp() OVERRIDE { 13 virtual void SetUp() OVERRIDE {
15 ExtensionManifestTest::SetUp(); 14 ExtensionManifestTest::SetUp();
16 extensions::ManifestHandler::Register( 15 (new extensions::OptionsPageHandler)->Register();
17 extension_manifest_keys::kOptionsPage,
18 make_linked_ptr(new extensions::OptionsPageHandler));
19 } 16 }
20 }; 17 };
21 18
22 TEST_F(OptionsPageManifestTest, OptionsPageInApps) { 19 TEST_F(OptionsPageManifestTest, OptionsPageInApps) {
23 scoped_refptr<extensions::Extension> extension; 20 scoped_refptr<extensions::Extension> extension;
24 21
25 // Allow options page with absolute URL in hosted apps. 22 // Allow options page with absolute URL in hosted apps.
26 extension = LoadAndExpectSuccess("hosted_app_absolute_options.json"); 23 extension = LoadAndExpectSuccess("hosted_app_absolute_options.json");
27 EXPECT_STREQ( 24 EXPECT_STREQ(
28 "http", 25 "http",
(...skipping 15 matching lines...) Expand all
44 Testcase("hosted_app_file_options.json", 41 Testcase("hosted_app_file_options.json",
45 errors::kInvalidOptionsPageInHostedApp), 42 errors::kInvalidOptionsPageInHostedApp),
46 43
47 // Forbid absolute URL for options page in packaged apps. 44 // Forbid absolute URL for options page in packaged apps.
48 Testcase("packaged_app_absolute_options.json", 45 Testcase("packaged_app_absolute_options.json",
49 errors::kInvalidOptionsPageExpectUrlInPackage) 46 errors::kInvalidOptionsPageExpectUrlInPackage)
50 }; 47 };
51 RunTestcases(testcases, arraysize(testcases), 48 RunTestcases(testcases, arraysize(testcases),
52 EXPECT_TYPE_ERROR); 49 EXPECT_TYPE_ERROR);
53 } 50 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698