Manifest handler for all keys background-related.

chrome/common/extensions/extension_file_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_file_util.h"
 
 #include <map>
 #include <vector>
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/stringprintf.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/api/extension_action/action_info.h"
 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h"
 #include "chrome/common/extensions/api/i18n/default_locale_handler.h"
 #include "chrome/common/extensions/api/themes/theme_handler.h"
+#include "chrome/common/extensions/background_info.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_l10n_util.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/extensions/extension_resource.h"
 #include "chrome/common/extensions/manifest.h"
 #include "chrome/common/extensions/manifest_url_handler.h"
 #include "chrome/common/extensions/message_bundle.h"
 #include "extensions/common/install_warning.h"
 #include "grit/generated_resources.h"
@@ skipping 313 matching lines @@
   }
 
   action = extensions::ActionInfo::GetBrowserActionInfo(extension);
   if (action && !action->default_icon.empty() &&
       !ValidateExtensionIconSet(action->default_icon, extension,
           IDS_EXTENSION_LOAD_ICON_FOR_BROWSER_ACTION_FAILED, error)) {
     return false;
   }
 
   // Validate that background scripts exist.
-  for (size_t i = 0; i < extension->background_scripts().size(); ++i) {
+  const std::vector<std::string>& background_scripts =
+      extensions::BackgroundInfo::GetBackgroundScripts(extension);
+  for (size_t i = 0; i < background_scripts.size(); ++i) {
     if (!file_util::PathExists(
-            extension->GetResource(
-                extension->background_scripts()[i]).GetFilePath())) {
+            extension->GetResource(background_scripts[i]).GetFilePath())) {
       *error = l10n_util::GetStringFUTF8(
           IDS_EXTENSION_LOAD_BACKGROUND_SCRIPT_FAILED,
-          UTF8ToUTF16(extension->background_scripts()[i]));
+          UTF8ToUTF16(background_scripts[i]));
       return false;
     }
   }
 
   // Validate background page location, except for hosted apps, which should use
   // an external URL. Background page for hosted apps are verified when the
   // extension is created (in Extension::InitFromValue)
-  if (extension->has_background_page() &&
+  if (extensions::BackgroundInfo::HasBackgroundPage(extension) &&
       !extension->is_hosted_app() &&
-      extension->background_scripts().empty()) {
+      extensions::BackgroundInfo::GetBackgroundScripts(extension).empty()) {

[Matt Perry, 2013/02/15 20:15:02]

already have background_scripts

[Yoyo Zhou, 2013/02/16 00:54:04]

Not sure I understand this comment.

[Matt Perry, 2013/02/16 01:16:52]

you cache the scripts in |background_scripts| above - no need to call the
function again.

     base::FilePath page_path = ExtensionURLToRelativeFilePath(
-        extension->GetBackgroundURL());
+        extensions::BackgroundInfo::GetBackgroundURL(extension));
     const base::FilePath path = extension->GetResource(page_path).GetFilePath();
     if (path.empty() || !file_util::PathExists(path)) {
       *error =
           l10n_util::GetStringFUTF8(
               IDS_EXTENSION_LOAD_BACKGROUND_PAGE_FAILED,
               page_path.LossyDisplayName());
       return false;
     }
   }
 
@@ skipping 384 matching lines @@
     return base::FilePath();
   }
   return temp_path;
 }
 
 void DeleteFile(const base::FilePath& path, bool recursive) {
   file_util::Delete(path, recursive);
 }
 
 }  // namespace extension_file_util