[sync] Fix deadlock in SessionModelAssociator for Android.

chrome/browser/sync/glue/session_model_associator.cc

Index: chrome/browser/sync/glue/session_model_associator.cc
diff --git a/chrome/browser/sync/glue/session_model_associator.cc b/chrome/browser/sync/glue/session_model_associator.cc
index 19109b7c879d30abd3f0640659ae7437d1083efb..ff7444a24228f65dd9c1db788618c8e86fc9187e 100644
--- a/chrome/browser/sync/glue/session_model_associator.cc
+++ b/chrome/browser/sync/glue/session_model_associator.cc
@@ -613,6 +613,9 @@ syncer::SyncError SessionModelAssociator::AssociateModels(
 
   scoped_ptr<DeviceInfo> local_device_info(sync_service_->GetLocalDeviceInfo());
 
+#if defined(OS_ANDROID)
+  std::string transaction_tag;
+#endif
   // Read any available foreign sessions and load any session data we may have.
   // If we don't have any local session data in the db, create a header node.
   {
@@ -672,11 +675,13 @@ syncer::SyncError SessionModelAssociator::AssociateModels(
       local_session_syncid_ = write_node.GetId();
     }
 #if defined(OS_ANDROID)
-    std::string transaction_tag = GetMachineTagFromTransaction(&trans);
-    if (current_machine_tag_.compare(transaction_tag) != 0)
-      DeleteForeignSession(transaction_tag);
+    transaction_tag = GetMachineTagFromTransaction(&trans);
 #endif
   }
+#if defined(OS_ANDROID)
+  if (current_machine_tag_.compare(transaction_tag) != 0)

[Yaron, 2013/02/13 21:01:47]

While I'm not excited about add a comment about implementation details, it does
seem worth calling out why this is done afterwards. Either that, or refactor the
code to re-use a transaction and/or a test.

Ok to do refactor/cleanup in a follow-up given the intent to merge to branch.

+    DeleteForeignSession(transaction_tag);
+#endif
 
   // Check if anything has changed on the client side.
   if (!UpdateSyncModelDataFromClient(&error)) {