Fresh drop of analyzer-experimental.

Fresh drop of analyzer-experimental.

Among other things, 
  * adds resolver and tests (in progress)
  * more tests in general (e.g., ast_test.dart and element_test.dart)
  * fixes getter/setter name generation
Committed: https://code.google.com/p/dart/source/detail?r=18535

[scheglov, 2013-02-13 19:36:35]

LGTM

[danrubel, 2013-02-13 20:28:50]

LGTM

https://codereview.chromium.org/12253009/diff/1/pkg/analyzer-experimental/lib...
File pkg/analyzer-experimental/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/12253009/diff/1/pkg/analyzer-experimental/lib...
pkg/analyzer-experimental/lib/src/generated/ast.dart:45: ;
No idea where this extraneous semi-colon came from.

https://codereview.chromium.org/12253009/diff/1/pkg/analyzer-experimental/lib...
File pkg/analyzer-experimental/lib/src/generated/element.dart (right):

https://codereview.chromium.org/12253009/diff/1/pkg/analyzer-experimental/lib...
pkg/analyzer-experimental/lib/src/generated/element.dart:909: if (((typeVariable
as TypeVariableElementImpl)).identifier == identifier19) {
extraneous parenthesis

[Jennifer Messerly, 2013-02-13 21:36:54]

lgtm, so cool!

https://codereview.chromium.org/12253009/diff/1/pkg/analyzer-experimental/lib...
File pkg/analyzer-experimental/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/12253009/diff/1/pkg/analyzer-experimental/lib...
pkg/analyzer-experimental/lib/src/generated/ast.dart:145: node.parent = this;
yay!

https://codereview.chromium.org/12253009/diff/1/pkg/analyzer-experimental/lib...
pkg/analyzer-experimental/lib/src/generated/ast.dart:669: ArgumentList({Token
leftParenthesis, List<Expression> arguments, Token rightParenthesis}) :
this.full(leftParenthesis, arguments, rightParenthesis);
nice, I liked the named args here!

https://codereview.chromium.org/12253009/diff/1/pkg/analyzer-experimental/lib...
pkg/analyzer-experimental/lib/src/generated/ast.dart:11027: class NodeLocator
extends GeneralizingASTVisitor<Object> {
nice, very useful for answering the question of "what node is at my cursor" :)

https://codereview.chromium.org/12253009/diff/1/pkg/analyzer-experimental/lib...
File pkg/analyzer-experimental/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/12253009/diff/1/pkg/analyzer-experimental/lib...
pkg/analyzer-experimental/lib/src/generated/engine.dart:20: class AnalysisEngine
{
Can't wait to try using this! Would be nice to have an example too when it's
ready :)

(The parser example was a nice starting point.)

[pquitslund, 2013-02-14 19:57:01]

Thanks all.  This is landed.

Have fun!  :)