Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1225243002: WebWaitableEvent: implement new API with ResetPolicy and InitialState arguments (Closed)

Created:
5 years, 5 months ago by Takashi Toyoshima
Modified:
5 years, 5 months ago
Reviewers:
kinuko, tkent
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebWaitableEvent: implement new API with ResetPolicy and InitialState arguments To support manual reset event in blink, implement new blink API to create WebWaitableEvent with two new arguments. BUG=507224 Committed: https://crrev.com/bffe514b23e06dc98b3cba2601f69ade39bdb5fa Cr-Commit-Position: refs/heads/master@{#338045}

Patch Set 1 #

Patch Set 2 : reflect blink side update #

Total comments: 3

Patch Set 3 : again #

Patch Set 4 : done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M content/child/blink_platform_impl.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 2 chunks +16 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1228713005 Patch 1

Messages

Total messages: 12 (3 generated)
Takashi Toyoshima
Chromium side implementation is here. kinuko: for OWNERS review tkent: FYI to show a series ...
5 years, 5 months ago (2015-07-09 07:22:59 UTC) #2
kinuko
lgtm, thanks! https://codereview.chromium.org/1225243002/diff/20001/content/child/blink_platform_impl.h File content/child/blink_platform_impl.h (right): https://codereview.chromium.org/1225243002/diff/20001/content/child/blink_platform_impl.h#newcode100 content/child/blink_platform_impl.h:100: blink::WebWaitableEvent::Reset reset, nit: as I commented I ...
5 years, 5 months ago (2015-07-09 08:05:54 UTC) #3
Takashi Toyoshima
done. I'll submit this change once blink is rolled. https://codereview.chromium.org/1225243002/diff/20001/content/child/blink_platform_impl.cc File content/child/blink_platform_impl.cc (right): https://codereview.chromium.org/1225243002/diff/20001/content/child/blink_platform_impl.cc#newcode100 content/child/blink_platform_impl.cc:100: ...
5 years, 5 months ago (2015-07-09 08:18:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225243002/60001
5 years, 5 months ago (2015-07-09 14:19:37 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-09 15:21:42 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/bffe514b23e06dc98b3cba2601f69ade39bdb5fa Cr-Commit-Position: refs/heads/master@{#338045}
5 years, 5 months ago (2015-07-09 15:23:45 UTC) #9
pdr.
On 2015/07/09 at 15:23:45, commit-bot wrote: > Patchset 4 (id:??) landed as https://crrev.com/bffe514b23e06dc98b3cba2601f69ade39bdb5fa > Cr-Commit-Position: ...
5 years, 5 months ago (2015-07-09 18:44:37 UTC) #10
pdr.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1229113002/ by pdr@chromium.org. ...
5 years, 5 months ago (2015-07-09 18:45:19 UTC) #11
Takashi Toyoshima
5 years, 5 months ago (2015-07-09 19:18:01 UTC) #12
Message was sent while issue was closed. 
this is wrong CL to revert. I'll revert another CL in blink side.

Powered by Google App Engine
This is Rietveld 408576698