Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 1225213014: go back to ps #4

Created:
5 years, 5 months ago by jungshik at Google
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust atomic ops code to work better with TSAN This is going back to PS #4 of https://codereview.chromium.org/1148463002/ because PS #5 made non-clang compiler unhappy. Takes an upstream patch (to be included in 56.x release) and patch our ICU 54. Clang-specific atomic ops will be used when clang is used to compile but C+11 atomic is disabled/unavailable. patch: http://bugs.icu-project.org/trac/changeset/37326 bug: http://bugs.icu-project.org/trac/ticket/11599 BUG=466959, 508049, 508440 TEST=See bugs TBR=thakis@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -4 lines) Patch
M README.chromium View 1 chunk +5 lines, -0 lines 0 comments Download
A patches/mutex.patch View 1 chunk +110 lines, -0 lines 0 comments Download
M source/common/putilimp.h View 2 chunks +21 lines, -1 line 0 comments Download
M source/common/umutex.h View 2 chunks +28 lines, -1 line 0 comments Download
M source/common/umutex.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698