Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 12252036: Fix RTL issue in the extensions page. (Closed)

Created:
7 years, 10 months ago by Adrian Kuegel
Modified:
7 years, 10 months ago
Reviewers:
Finnur, jeremy
CC:
chromium-reviews, Aaron Boodman, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

For two elements (the webstore icon and the configure commands link) the handling for rtl direction was missing. This changelist addresses this issue. See screenshots here: before: https://docs.google.com/a/google.com/file/d/0BzMCIwDgeNezS05UWTFOUkZoSUE/edit?usp=sharing after: https://docs.google.com/a/google.com/file/d/0BzMCIwDgeNezUjlQV05zZkIxcFU/edit?usp=sharing BUG=176255 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182780

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/resources/extensions/extensions.css View 3 chunks +9 lines, -1 line 2 comments Download

Messages

Total messages: 12 (0 generated)
Adrian Kuegel
Hi Jeremy, can you please review my changes? Kind regards, Adrian
7 years, 10 months ago (2013-02-14 13:21:09 UTC) #1
jeremy
Can you please send me a before/after screenshot? Also in the screenshot you sent the ...
7 years, 10 months ago (2013-02-14 13:23:26 UTC) #2
Adrian Kuegel
Thanks for the fast response. It seems there are more RTL issues with this page ...
7 years, 10 months ago (2013-02-14 13:30:43 UTC) #3
jeremy
The checkbox graphic should look the same as it does in LTR, if you look ...
7 years, 10 months ago (2013-02-14 13:33:27 UTC) #4
Adrian Kuegel
I have some difficulties with creating screenshots using Hebrew. Everytime I try to start Chrome ...
7 years, 10 months ago (2013-02-14 13:50:37 UTC) #5
jeremy
LGTM, please get a review from someone who might have an opinion on the html ...
7 years, 10 months ago (2013-02-14 13:56:04 UTC) #6
Adrian Kuegel
Yes, I will file a bug about the checkmarks. Thanks for your very fast responses ...
7 years, 10 months ago (2013-02-14 14:02:34 UTC) #7
Adrian Kuegel
Sorry, forgot to include the comment (see below). https://codereview.chromium.org/12252036/diff/1/chrome/browser/resources/extensions/extensions.css File chrome/browser/resources/extensions/extensions.css (right): https://codereview.chromium.org/12252036/diff/1/chrome/browser/resources/extensions/extensions.css#newcode321 chrome/browser/resources/extensions/extensions.css:321: } ...
7 years, 10 months ago (2013-02-14 14:03:09 UTC) #8
Adrian Kuegel
Finnur, could you please review this changelist and give me OWNERS approval?
7 years, 10 months ago (2013-02-14 14:04:26 UTC) #9
Finnur
OWNERS LGTM. Note that I'm on paternity leave, so expect delays in replying. :)
7 years, 10 months ago (2013-02-15 10:23:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/12252036/1
7 years, 10 months ago (2013-02-15 10:43:41 UTC) #11
commit-bot: I haz the power
7 years, 10 months ago (2013-02-15 19:27:02 UTC) #12
Message was sent while issue was closed.
Change committed as 182780

Powered by Google App Engine
This is Rietveld 408576698