Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 12252029: [sync] Re-enable SyncErrorTest.XmppAuthErrorTest (Closed)

Created:
7 years, 10 months ago by Raghu Simha
Modified:
7 years, 10 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

[sync] Re-enable SyncErrorTest.XmppAuthErrorTest The sync integration test SyncErrorTest.XmppAuthErrorTest was flaky on Mac due to typed_url_data_type_controller.cc not being able to access the history service. It appears that recent changes have fixed the flakiness, and the test passes with large --gtest_repeat numbers. Enabling this once the trybots are satisfied. BUG=165328 TEST=SyncErrorTest.XmppAuthErrorTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/sync/test/integration/sync_errors_test.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Raghu Simha
Nicolas, please review. Thanks.
7 years, 10 months ago (2013-02-14 01:44:45 UTC) #1
Nicolas Zea
7 years, 10 months ago (2013-02-14 01:48:13 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698