Issue 12252024: Revert 182331

Issue 12252024: Revert 182331 (Closed)

Created:
7 years, 10 months ago by Ryan Hamilton

Modified:
7 years, 10 months ago

Reviewers:
eroman, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 182331 > Enhance net internals/net log output for QUIC. > > > Review URL: https://chromiumcodereview.appspot.com/12207020 TBR=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182335

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -109 lines)			Patch
M	chrome/browser/resources/net_internals/quic_view.js	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/test/data/webui/net_internals/log_view_painter.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/base/net_log_event_type_list.h	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	net/base/net_log_source_type_list.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_client_session.h	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	net/quic/quic_client_session.cc	View	3 chunks	+3 lines, -16 lines	0 comments	Download
M	net/quic/quic_client_session_test.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	net/quic/quic_http_stream.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/quic/quic_http_stream.cc	View	4 chunks	+0 lines, -34 lines	0 comments	Download
M	net/quic/quic_http_stream_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_reliable_client_stream.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	net/quic/quic_reliable_client_stream.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/quic/quic_reliable_client_stream_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_stream_factory.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mmenke

On 2013/02/13 23:28:26, eroman wrote: > What is the reason for the revert? Linux ASAN ...

7 years, 10 months ago (2013-02-13 23:36:37 UTC) #3

Ryan Hamilton

7 years, 10 months ago (2013-02-14 00:33:16 UTC) #4

On Wed, Feb 13, 2013 at 3:36 PM, <mmenke@chromium.org> wrote:

> On 2013/02/13 23:28:26, eroman wrote:
>
>> What is the reason for the revert?
>>
>
> Linux ASAN was sad.
> http://build.chromium.org/p/**chromium.memory/buildstatus?**
>
builder=Linux%20ASAN%20Tests%**20%281%29&number=6458<http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Tests%20%281%29&number=6458>
>
>
https://codereview.chromium.**org/12252024/<https://codereview.chromium.org/1...

Yes, it appears I did something wrong and ended up with a use after free of
the net log :|  I'll get to the bottom of it.

Expand Messages | Collapse Messages