Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: content/browser/web_contents/render_view_host_manager.cc

Issue 12252016: Prevented connecting drag drop events to a SwappedOut RenderViewHost in WebContentsViewGtk (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: A step back... Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/render_view_host_manager.cc
diff --git a/content/browser/web_contents/render_view_host_manager.cc b/content/browser/web_contents/render_view_host_manager.cc
index 2abf1ff716fb7fd0ff8ca462cb985c8b9558b4ce..e9f8acc0c8b9906948a8b0a63737cafd2fe0ba23 100644
--- a/content/browser/web_contents/render_view_host_manager.cc
+++ b/content/browser/web_contents/render_view_host_manager.cc
@@ -646,14 +646,16 @@ int RenderViewHostManager::CreateRenderView(
}
bool success = InitRenderView(new_render_view_host, opener_route_id);
- if (success) {
- // Don't show the view until we get a DidNavigate from it.
- new_render_view_host->GetView()->Hide();
+ if (!swapped_out) {
+ if (success) {
+ // Don't show the view until we get a DidNavigate from it.
+ new_render_view_host->GetView()->Hide();
- // TODO(nasko): Send a frame tree update when creating the RV
- // once http://crbug.com/153701 is fixed.
- } else if (!swapped_out) {
- CancelPending();
+ // TODO(nasko): Send a frame tree update when creating the RV
+ // once http://crbug.com/153701 is fixed.
+ } else {
+ CancelPending();
+ }
}
}
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698