content/browser/web_contents/web_contents_view_aura.cc - Issue 12252016: Prevented connecting drag drop events to a SwappedOut RenderViewHost in WebContentsViewGtk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 12252016: Prevented connecting drag drop events to a SwappedOut RenderViewHost in WebContentsViewGtk (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_view_aura.h ('k') | content/browser/web_contents/web_contents_view_gtk.h » ('j') | content/browser/web_contents/web_contents_view_gtk.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_view_aura.cc

diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc

index 4ca716dbf484a152fba67f3041b3f7f5e77ef565..3a4ed2da781de47d7688fedcfce563cd15d0b036 100644

--- a/content/browser/web_contents/web_contents_view_aura.cc

+++ b/content/browser/web_contents/web_contents_view_aura.cc

@@ -1280,10 +1280,11 @@ void WebContentsViewAura::SetPageTitle(const string16& title) {

void WebContentsViewAura::RenderViewCreated(RenderViewHost* host) {

}

-void WebContentsViewAura::RenderViewSwappedIn(RenderViewHost* host) {

+void WebContentsViewAura::RenderViewSwappedIn(RenderViewHost* new_host,

+ RenderViewHost* old_host) {

if (navigation_overlay_.get() && navigation_overlay_->has_window()) {

navigation_overlay_->StartObservingView(static_cast<

- RenderWidgetHostViewAura*>(host->GetView()));

+ RenderWidgetHostViewAura*>(new_host->GetView()));

}