Prevented connecting drag drop events to a SwappedOut RenderViewHost in WebContentsViewGtk

content/browser/web_contents/web_drag_dest_gtk.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_DRAG_DEST_GTK_H_
 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_DRAG_DEST_GTK_H_
 
 #include <gtk/gtk.h>
 
 #include "base/gtest_prod_util.h"
@@ skipping 23 matching lines @@
   // update the system drag cursor.
   void UpdateDragStatus(WebKit::WebDragOperation operation);
 
   // Informs the renderer when a system drag has left the render view.
   // See OnDragLeave().
   void DragLeave();
 
   WebDragDestDelegate* delegate() const { return delegate_; }
   void set_delegate(WebDragDestDelegate* delegate) { delegate_ = delegate; }
 
+  GtkWidget* widget() const { return widget_; }
+
  private:
   RenderViewHostImpl* GetRenderViewHost() const;
 
   // Called when a system drag crosses over the render view. As there is no drag
   // enter event, we treat it as an enter event (and not a regular motion event)
   // when |context_| is NULL.
   CHROMEGTK_CALLBACK_4(WebDragDestGtk, gboolean, OnDragMotion, GdkDragContext*,
                        gint, gint, guint);
 
   // We make a series of requests for the drag data when the drag first enters
@@ skipping 29 matching lines @@
   // source.
   int data_requests_;
 
   // The last time we sent a message to the renderer related to a drag motion.
   gint drag_over_time_;
 
   // Whether the cursor is over a drop target, according to the last message we
   // got from the renderer.
   bool is_drop_target_;
 
-  // Handler ID for the destroy signal handler. We connect to the destroy
-  // signal handler so that we won't call dest_unset on it after it is
-  // destroyed, but we have to cancel the handler if we are destroyed before
-  // |widget_| is.
-  int destroy_handler_;
+  // Stores Handler IDs for the gtk signal handlers. We have to cancel the the

[Charlie Reis, 2013/03/14 22:08:38]

typo: the the

[mthiesse, 2013/03/15 15:26:49]

Done.

+  // signal handlers when this WebDragDestGtk is deleted so that if, later on,
+  // we re-create the drag dest with the same same widget that we don't get

[Charlie Reis, 2013/03/14 22:08:38]

so that if we later recreate...
typo: same same

"that we don't" doesn't sound right.  I think you want to replace "that" with a
comma.

[mthiesse, 2013/03/15 15:26:49]

Done.

+  // callbacks to deleted functions.
+  scoped_array<int> handlers_;
 
   // A delegate that can receive drag information about drag events.
   WebDragDestDelegate* delegate_;
 
   base::WeakPtrFactory<WebDragDestGtk> method_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebDragDestGtk);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_WEB_CONTENTS_WEB_DRAG_DEST_GTK_H_