Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: content/browser/web_contents/web_contents_view_gtk.h

Issue 12252016: Prevented connecting drag drop events to a SwappedOut RenderViewHost in WebContentsViewGtk (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed issues preventing the setting of the drag_dest_ on RenderViewSwappedIn Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_GTK_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_GTK_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_GTK_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_GTK_H_
7 7
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 virtual void GotFocus() OVERRIDE; 90 virtual void GotFocus() OVERRIDE;
91 virtual void TakeFocus(bool reverse) OVERRIDE; 91 virtual void TakeFocus(bool reverse) OVERRIDE;
92 92
93 private: 93 private:
94 // Insert the given widget into the content area. Should only be used for 94 // Insert the given widget into the content area. Should only be used for
95 // web pages and the like (including interstitials and sad tab). Note that 95 // web pages and the like (including interstitials and sad tab). Note that
96 // this will be perfectly happy to insert overlapping render views, so care 96 // this will be perfectly happy to insert overlapping render views, so care
97 // should be taken that the correct one is hidden/shown. 97 // should be taken that the correct one is hidden/shown.
98 void InsertIntoContentArea(GtkWidget* widget); 98 void InsertIntoContentArea(GtkWidget* widget);
99 99
100 void UpdateDragDest(RenderViewHost* new_host);
Charlie Reis 2013/03/14 22:08:38 Please add a comment saying when this needs to be
mthiesse 2013/03/15 15:26:49 Done.
101
100 // Handle focus traversal on the render widget native view. Can be overridden 102 // Handle focus traversal on the render widget native view. Can be overridden
101 // by subclasses. 103 // by subclasses.
102 CHROMEGTK_CALLBACK_1(WebContentsViewGtk, gboolean, OnFocus, GtkDirectionType); 104 CHROMEGTK_CALLBACK_1(WebContentsViewGtk, gboolean, OnFocus, GtkDirectionType);
103 105
104 // Used to adjust the size of its children when the size of |expanded_| is 106 // Used to adjust the size of its children when the size of |expanded_| is
105 // changed. 107 // changed.
106 CHROMEGTK_CALLBACK_2(WebContentsViewGtk, void, OnChildSizeRequest, 108 CHROMEGTK_CALLBACK_2(WebContentsViewGtk, void, OnChildSizeRequest,
107 GtkWidget*, GtkRequisition*); 109 GtkWidget*, GtkRequisition*);
108 110
109 // Used to propagate the size change of |expanded_| to our RWHV to resize the 111 // Used to propagate the size change of |expanded_| to our RWHV to resize the
(...skipping 25 matching lines...) Expand all
135 // The size we want the view to be. We keep this in a separate variable 137 // The size we want the view to be. We keep this in a separate variable
136 // because resizing in GTK+ is async. 138 // because resizing in GTK+ is async.
137 gfx::Size requested_size_; 139 gfx::Size requested_size_;
138 140
139 DISALLOW_COPY_AND_ASSIGN(WebContentsViewGtk); 141 DISALLOW_COPY_AND_ASSIGN(WebContentsViewGtk);
140 }; 142 };
141 143
142 } // namespace content 144 } // namespace content
143 145
144 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_GTK_H_ 146 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_GTK_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698