Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: content/browser/web_contents/web_contents_view_guest.cc

Issue 12252016: Prevented connecting drag drop events to a SwappedOut RenderViewHost in WebContentsViewGtk (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Use RenderViewSwappedIn to ensure we have a drag dest Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_guest.h" 5 #include "content/browser/web_contents/web_contents_view_guest.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "content/browser/browser_plugin/browser_plugin_guest.h" 8 #include "content/browser/browser_plugin/browser_plugin_guest.h"
9 #include "content/browser/renderer_host/render_view_host_factory.h" 9 #include "content/browser/renderer_host/render_view_host_factory.h"
10 #include "content/browser/renderer_host/render_view_host_impl.h" 10 #include "content/browser/renderer_host/render_view_host_impl.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 return RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host); 108 return RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);
109 } 109 }
110 110
111 void WebContentsViewGuest::SetPageTitle(const string16& title) { 111 void WebContentsViewGuest::SetPageTitle(const string16& title) {
112 } 112 }
113 113
114 void WebContentsViewGuest::RenderViewCreated(RenderViewHost* host) { 114 void WebContentsViewGuest::RenderViewCreated(RenderViewHost* host) {
115 platform_view_->RenderViewCreated(host); 115 platform_view_->RenderViewCreated(host);
116 } 116 }
117 117
118 void WebContentsViewGuest::RenderViewSwappedIn(RenderViewHost* host) { 118 void WebContentsViewGuest::RenderViewSwappedIn(RenderViewHost* new_host,
119 platform_view_->RenderViewSwappedIn(host); 119 RenderViewHost* old_host) {
120 platform_view_->RenderViewSwappedIn(new_host, old_host);
120 } 121 }
121 122
122 #if defined(OS_MACOSX) 123 #if defined(OS_MACOSX)
123 bool WebContentsViewGuest::IsEventTracking() const { 124 bool WebContentsViewGuest::IsEventTracking() const {
124 return false; 125 return false;
125 } 126 }
126 127
127 void WebContentsViewGuest::CloseTabAfterEventTracking() { 128 void WebContentsViewGuest::CloseTabAfterEventTracking() {
128 } 129 }
129 #endif 130 #endif
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 void WebContentsViewGuest::StartDragging( 184 void WebContentsViewGuest::StartDragging(
184 const WebDropData& drop_data, 185 const WebDropData& drop_data,
185 WebDragOperationsMask ops, 186 WebDragOperationsMask ops,
186 const gfx::ImageSkia& image, 187 const gfx::ImageSkia& image,
187 const gfx::Vector2d& image_offset, 188 const gfx::Vector2d& image_offset,
188 const DragEventSourceInfo& event_info) { 189 const DragEventSourceInfo& event_info) {
189 NOTIMPLEMENTED(); 190 NOTIMPLEMENTED();
190 } 191 }
191 192
192 } // namespace content 193 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698