Make proxy fallback logic more captive-portal friendly,

Make proxy fallback logic more captive-portal friendly,
particularly in the case of SSL proxies.

Errors that one is likely to see when trying to talk SSL
to a captive portal now trigger fallback.

The errors are:

ERR_CONNECTION_TIMED_OUT (Portal blackholes SSL)
ERR_PROXY_CERTIFICATE_INVALID (Portal uses self-signed cert)
ERR_SSL_PROTOCOL_ERROR (Portal talks HTTP over port 443)

BUG=176053
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182411

[mmenke, 2013-02-13 21:01:16]

Well, this turned out to be much easier than expected.  Had no idea that we had
a whitelist for this, so had been assuming there was an issue with the machanism
missing relevant errors.

[mmenke, 2013-02-13 21:45:43]

On 2013/02/13 21:01:16, mmenke wrote:
> Well, this turned out to be much easier than expected.  Had no idea that we
had
> a whitelist for this, so had been assuming there was an issue with the
machanism
> missing relevant errors.

I'm happy to add unit tests for this for this, just not sure it's worth it.  We
certainly care if these regress, suggesting it may be a good idea, but it's a
really simple patch, so I was thinking existing tests would be fine, as we don't
want to check every single case in the whitelist.

[eroman, 2013-02-14 00:03:47]

lgtm

https://codereview.chromium.org/12252015/diff/11001/net/http/http_stream_fact...
File net/http/http_stream_factory_impl_job.cc (right):

https://codereview.chromium.org/12252015/diff/11001/net/http/http_stream_fact...
net/http/http_stream_factory_impl_job.cc:1185: // This can happen in the case of
trying to use an HTTPS proxy while behind
Please word this differently. "HTTPS proxy" can mean 1 of two things:

  - An HTTP proxy for https:// URLs
  - A spdy proxy (proxy scheme=https)

https://codereview.chromium.org/12252015/diff/11001/net/http/http_stream_fact...
net/http/http_stream_factory_impl_job.cc:1197: // Note that if the host
resolving was done by the SOCKS5 proxy, we can't
hah!

[mmenke, 2013-02-14 00:28:10]

https://codereview.chromium.org/12252015/diff/11001/net/http/http_stream_fact...
File net/http/http_stream_factory_impl_job.cc (right):

https://codereview.chromium.org/12252015/diff/11001/net/http/http_stream_fact...
net/http/http_stream_factory_impl_job.cc:1185: // This can happen in the case of
trying to use an HTTPS proxy while behind
On 2013/02/14 00:03:47, eroman wrote:
> Please word this differently. "HTTPS proxy" can mean 1 of two things:
> 
>   - An HTTP proxy for https:// URLs
>   - A spdy proxy (proxy scheme=https)

Wait..."An HTTP proxy for https:// URLs"?  Not an "HTTP proxy layered on top of
SSL (ie. HTTPS) for either HTTP or HTTPS urls?"

If it's actually the second, it applies to both cases.

[mmenke, 2013-02-14 00:52:39]

https://codereview.chromium.org/12252015/diff/11001/net/http/http_stream_fact...
File net/http/http_stream_factory_impl_job.cc (right):

https://codereview.chromium.org/12252015/diff/11001/net/http/http_stream_fact...
net/http/http_stream_factory_impl_job.cc:1185: // This can happen in the case of
trying to use an HTTPS proxy while behind
On 2013/02/14 00:28:11, mmenke wrote:
> On 2013/02/14 00:03:47, eroman wrote:
> > Please word this differently. "HTTPS proxy" can mean 1 of two things:
> > 
> >   - An HTTP proxy for https:// URLs
> >   - A spdy proxy (proxy scheme=https)
> 
> Wait..."An HTTP proxy for https:// URLs"?  Not an "HTTP proxy layered on top
of
> SSL (ie. HTTPS) for either HTTP or HTTPS urls?"
> 
> If it's actually the second, it applies to both cases.

I've updated it to be neutral ("Talking to a proxy using SSL").

[eroman, 2013-02-14 01:25:43]

normally when someone says "https proxy" they mean an HTTP proxy being used for
https:// URLs (so the browser issues a CONNECT to send the ssl traffic to the
HTTP proxy).

however chrome adds support for an "https proxy", where you speak ssl to the
proxy server, and then send whatever you want through that

[mmenke, 2013-02-14 04:44:18]

On 2013/02/14 01:25:43, eroman wrote:
> normally when someone says "https proxy" they mean an HTTP proxy being used
for
> https:// URLs (so the browser issues a CONNECT to send the ssl traffic to the
> HTTP proxy).
> 
> however chrome adds support for an "https proxy", where you speak ssl to the
> proxy server, and then send whatever you want through that

Thanks for the explanation!

[commit-bot: I haz the power, 2013-02-14 04:45:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/12252015/13001