Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7444)

Unified Diff: chrome/test/ppapi/ppapi_test.cc

Issue 12252004: PPAPI/WS: use server providing hostname as test serevr hostname (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/tests/test_case.html » ('j') | ppapi/tests/test_case.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ppapi/ppapi_test.cc
diff --git a/chrome/test/ppapi/ppapi_test.cc b/chrome/test/ppapi/ppapi_test.cc
index 2c1def44d16ace12c42195273474a742b450b5c3..5a6e7baaa4b1553ca077b013d02b094fe774da12 100644
--- a/chrome/test/ppapi/ppapi_test.cc
+++ b/chrome/test/ppapi/ppapi_test.cc
@@ -219,10 +219,13 @@ void PPAPITestBase::RunTestWithWebSocketServer(const std::string& test_case) {
ASSERT_TRUE(http_server.BlockUntilStarted());
ASSERT_TRUE(ws_server.BlockUntilStarted());
+ std::string host = ws_server.host_port_pair().host();
uint16_t port = ws_server.host_port_pair().port();
RunTestURL(GetTestURL(http_server,
test_case,
- StringPrintf("websocket_port=%d", port)));
+ StringPrintf("websocket_host=%s&websocket_port=%d",
+ host.c_str(),
dmichael (off chromium) 2013/02/13 21:41:13 nit: please line up the 2nd and 3rd params with th
Ryan Sleevi 2013/02/13 21:46:14 Do you need to worry about canonicalizing the host
Takashi Toyoshima 2013/02/14 08:28:28 Thank you for catching this. Yes, I should call Ho
Takashi Toyoshima 2013/02/14 08:28:28 Done.
+ port)));
}
void PPAPITestBase::RunTestIfAudioOutputAvailable(
« no previous file with comments | « no previous file | ppapi/tests/test_case.html » ('j') | ppapi/tests/test_case.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698