PPAPI/WS: use server providing hostname as test serevr hostname

PPAPI/WS: use server providing hostname as test serevr hostname

'localhost' can be resolved as IPv6 address and IPv4 address.
On the other hands, a test server listens at '127.0.0.1' by default.
Chrome want to connect using IPv6 address firstly. So if the server listens at
only IPv4 address, Chrome connects IPv4 address after IPv6 timeout.

This change passes server proviting host to PPAPI tests, then makes it
available from WebSocket related PPAPI tests.

BUG=175237
TEST=browser_tests --gtest_filter='*.WebSocket_*'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182452

[Takashi Toyoshima, 2013-02-13 11:17:39]

David

[Takashi Toyoshima, 2013-02-13 11:19:31]

Sorry, I mistakenly published an unfinished message.

Reviewer: David,
Could you review this CL to use server providing host name for WebSocket test
server? This will fix Win32 slow issue.

CC: Ryan,
This CL is based on your suggestion. Thanks!

[dmichael (off chromium), 2013-02-13 21:41:12]

lgtm

https://codereview.chromium.org/12252004/diff/1/chrome/test/ppapi/ppapi_test.cc
File chrome/test/ppapi/ppapi_test.cc (right):

https://codereview.chromium.org/12252004/diff/1/chrome/test/ppapi/ppapi_test....
chrome/test/ppapi/ppapi_test.cc:227: host.c_str(),
nit: please line up the 2nd and 3rd params with the 1st, since they fit

https://codereview.chromium.org/12252004/diff/1/ppapi/tests/test_case.html
File ppapi/tests/test_case.html (right):

https://codereview.chromium.org/12252004/diff/1/ppapi/tests/test_case.html#ne...
ppapi/tests/test_case.html:42: if (Websocket_host != "")
Websocket should be lower-case here

[Ryan Sleevi, 2013-02-13 21:46:14]

https://codereview.chromium.org/12252004/diff/1/chrome/test/ppapi/ppapi_test.cc
File chrome/test/ppapi/ppapi_test.cc (right):

https://codereview.chromium.org/12252004/diff/1/chrome/test/ppapi/ppapi_test....
chrome/test/ppapi/ppapi_test.cc:227: host.c_str(),
On 2013/02/13 21:41:13, dmichael wrote:
> nit: please line up the 2nd and 3rd params with the 1st, since they fit

Do you need to worry about canonicalizing the host, in the event of IPv6 (that
is: adding brackets).

See HostPortPair::HostForURL

[Takashi Toyoshima, 2013-02-14 08:28:28]

https://codereview.chromium.org/12252004/diff/1/chrome/test/ppapi/ppapi_test.cc
File chrome/test/ppapi/ppapi_test.cc (right):

https://codereview.chromium.org/12252004/diff/1/chrome/test/ppapi/ppapi_test....
chrome/test/ppapi/ppapi_test.cc:227: host.c_str(),
Thank you for catching this.
Yes, I should call HostForURL to get host string here.

https://codereview.chromium.org/12252004/diff/1/chrome/test/ppapi/ppapi_test....
chrome/test/ppapi/ppapi_test.cc:227: host.c_str(),
On 2013/02/13 21:41:13, dmichael wrote:
> nit: please line up the 2nd and 3rd params with the 1st, since they fit

Done.

https://codereview.chromium.org/12252004/diff/1/ppapi/tests/test_case.html
File ppapi/tests/test_case.html (right):

https://codereview.chromium.org/12252004/diff/1/ppapi/tests/test_case.html#ne...
ppapi/tests/test_case.html:42: if (Websocket_host != "")
Thank you for finding this.
Fixed.

[commit-bot: I haz the power, 2013-02-14 08:30:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/12252004/2004