CreateThread interception, to use CreateRemoteThread

sandbox/win/src/process_thread_policy.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/win/src/process_thread_policy.h"
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "sandbox/win/src/ipc_tags.h"
@@ skipping 79 matching lines @@
       return false;
     };
   }
 
   if (!process->AddStringMatch(IF, NameBased::NAME, name, CASE_INSENSITIVE)) {
     return false;
   }
   if (!policy->AddRule(IPC_CREATEPROCESSW_TAG, process.get())) {
     return false;
   }
+  if (!policy->AddRule(IPC_CREATETHREAD_TAG, process.get())) {
+    return false;
+  }
   return true;
 }
 
 NTSTATUS ProcessPolicy::OpenThreadAction(const ClientInfo& client_info,
                                          uint32 desired_access,
                                          uint32 thread_id,
                                          HANDLE* handle) {
   *handle = NULL;
 
   NtOpenThreadFunction NtOpenThread = NULL;
@@ skipping 119 matching lines @@
   BOOL should_give_full_access = (GIVE_ALLACCESS == eval_result);
   if (!CreateProcessExWHelper(client_info.process, should_give_full_access,
                               app_name.c_str(), cmd_line.get(), NULL, NULL,
                               FALSE, 0, NULL, NULL, &startup_info,
                               process_info)) {
     return ERROR_ACCESS_DENIED;
   }
   return ERROR_SUCCESS;
 }
 
+DWORD ProcessPolicy::CreateThreadAction(EvalResult eval_result,
+  const ClientInfo& client_info,
+  const LPSECURITY_ATTRIBUTES thread_attributes,
+  const SIZE_T stack_size,
+  const LPTHREAD_START_ROUTINE start_address,
+  const PVOID parameter,
+  const DWORD creation_flags,
+  LPDWORD thread_id,
+  HANDLE *handle) {
+
+  // The only action supported is ASK_BROKER which means create the process.
+  if (GIVE_ALLACCESS != eval_result && GIVE_READONLY != eval_result) {

[Will Harris, 2015/09/04 02:41:01]

eval_result will always be GIVE_ALLACCESS

I wonder if we even need to pass the eval through unless we plan to change this
to allow policy based blocking for CreateThread

[liamjm (20p), 2015/09/04 21:30:39]

As discussed, this is more of a stylistic thing - do we match the existing
functions, or remove the redundant checks.
Will discuss with jschuh@ when he's back.

+    return ERROR_ACCESS_DENIED;
+  }
+  HANDLE local_handle = CreateRemoteThread(
+    client_info.process,
+    thread_attributes,
+    stack_size,
+    start_address,
+    parameter,
+    creation_flags,
+    thread_id);
+  if (!local_handle) {
+    return ERROR_ACCESS_DENIED;
+  }
+  if (!::DuplicateHandle(::GetCurrentProcess(), local_handle,
+    client_info.process, handle, 0, FALSE,
+    DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
+    // TODO(liamjm): what do we do on error with original handle??

[Will Harris, 2015/09/04 02:41:01]

I don't know but we probably need a DCHECK here

[liamjm (20p), 2015/09/04 21:30:39]

Added a DCHECK()

+    return ERROR_ACCESS_DENIED;
+  }
+  return ERROR_SUCCESS;
+}
+
 }  // namespace sandbox