components/dom_distiller/core/dom_distiller_request_view_base.h - Issue 1225183002: Font size in DomDistiller prefs syncs with local scaling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/dom_distiller_request_view_base.h

Issue 1225183002: Font size in DomDistiller prefs syncs with local scaling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: keep focus when useFontScaling() is called, add tests Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/dom_distiller/content/dom_distiller_viewer_source.cc ('K') | « components/dom_distiller/core/distilled_page_prefs_android.cc ('k') | components/dom_distiller/core/dom_distiller_request_view_base.cc » ('j') | components/dom_distiller/core/viewer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/core/dom_distiller_request_view_base.h

diff --git a/components/dom_distiller/core/dom_distiller_request_view_base.h b/components/dom_distiller/core/dom_distiller_request_view_base.h

index ef0fb9f0f8628f38a95e04f94bfa08f0aa1f07e8..0790a78e37b3f502746d6cf306df39ec31a93c62 100644

--- a/components/dom_distiller/core/dom_distiller_request_view_base.h

+++ b/components/dom_distiller/core/dom_distiller_request_view_base.h

@@ -45,9 +45,10 @@ class DomDistillerRequestViewBase : public ViewRequestDelegate,

protected:

// DistilledPagePrefs::Observer implementation:

+ void OnChangeTheme(DistilledPagePrefs::Theme new_theme) override;

void OnChangeFontFamily(

DistilledPagePrefs::FontFamily new_font_family) override;

- void OnChangeTheme(DistilledPagePrefs::Theme new_theme) override;

+ void OnChangeFontScaling(float scaling) override;

// Sends JavaScript to the attached Viewer, buffering data if the viewer isn't

// ready.