Font size in DomDistiller prefs syncs with local scaling

chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include "base/command_line.h"
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/dom_distiller/dom_distiller_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_isolated_world_ids.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/dom_distiller/content/browser/distiller_javascript_utils.h"
@@ skipping 40 matching lines @@
         "document.getElementById('loadingIndicator').className)";
 
 const char kGetContent[] =
     "window.domAutomationController.send("
         "document.getElementById('content').innerHTML)";
 
 const char kGetBodyClass[] =
     "window.domAutomationController.send("
         "document.body.className)";
 
+const char kGetFontSize[] =
+    "window.domAutomationController.send("
+        "window.getComputedStyle(document.documentElement).fontSize)";
+
 const unsigned kDarkToolbarThemeColor = 0xFF1A1A1A;
 
 const char kTestDistillerObject[] =
     "window.domAutomationController.send("
     "typeof distiller == 'object')";
 
 void AddEntry(const ArticleEntry& e, FakeDB<ArticleEntry>::EntryMap* map) {
   (*map)[e.entry_id()] = e;
 }
 
@@ skipping 52 matching lines @@
     if (expect_distiller_page_) {
       MockDistillerPage* distiller_page = new MockDistillerPage();
       EXPECT_CALL(*distiller_page_factory_, CreateDistillerPageImpl())
           .WillOnce(testing::Return(distiller_page));
     }
     return service.Pass();
   }
 
   void ViewSingleDistilledPage(const GURL& url,
                                const std::string& expected_mime_type);
+  void PrefTest(bool is_error_page);
   // Database entries.
   static FakeDB<ArticleEntry>::EntryMap* database_model_;
   static bool expect_distillation_;
   static bool expect_distiller_page_;
   static MockDistillerFactory* distiller_factory_;
 };
 
 FakeDB<ArticleEntry>::EntryMap*
     DomDistillerViewerSourceBrowserTest::database_model_;
 bool DomDistillerViewerSourceBrowserTest::expect_distillation_ = false;
@@ skipping 323 matching lines @@
   EXPECT_TRUE(content::ExecuteScriptAndExtractString(
       contents, kGetLoadIndicatorClassName, &result));
   EXPECT_EQ("hidden", result);
   EXPECT_TRUE(content::ExecuteScriptAndExtractString(
       contents, kGetContent , &result));
   EXPECT_THAT(result, HasSubstr("Page 1 content"));
   EXPECT_THAT(result, HasSubstr("Page 2 content"));
 }
 
 IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest, PrefChange) {
-  expect_distillation_ = true;
-  expect_distiller_page_ = true;
-  GURL view_url("http://www.example.com/1");
+  PrefTest(false);
+}
+
+IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest, PrefChangeError) {
+  PrefTest(true);
+}
+
+void DomDistillerViewerSourceBrowserTest::PrefTest(bool is_error_page) {
+  GURL url;
+  if (is_error_page) {
+    expect_distillation_ = false;
+    expect_distiller_page_ = false;
+    url = GURL("chrome-distiller://bad");
+  } else {
+    expect_distillation_ = true;
+    expect_distiller_page_ = true;
+    GURL view_url("http://www.example.com/1");
+    url = url_utils::GetDistillerViewUrlFromUrl(kDomDistillerScheme, view_url);
+  }
   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();
-  const GURL url =
-      url_utils::GetDistillerViewUrlFromUrl(kDomDistillerScheme, view_url);
   ViewSingleDistilledPage(url, "text/html");
   content::WaitForLoadStop(contents);
   std::string result;
   EXPECT_TRUE(content::ExecuteScriptAndExtractString(
       contents, kGetBodyClass, &result));
   EXPECT_EQ("light sans-serif", result);
 
   DistilledPagePrefs* distilled_page_prefs =
        DomDistillerServiceFactory::GetForBrowserContext(
             browser()->profile())->GetDistilledPagePrefs();
 
+  // Test theme.
   distilled_page_prefs->SetTheme(DistilledPagePrefs::DARK);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(content::ExecuteScriptAndExtractString(
       contents, kGetBodyClass, &result));
   EXPECT_EQ("dark sans-serif", result);
 
   // Verify that the theme color for the tab is updated as well.
   EXPECT_EQ(kDarkToolbarThemeColor, contents->GetThemeColor());
 
+  // Test font family.
   distilled_page_prefs->SetFontFamily(DistilledPagePrefs::SERIF);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(
       content::ExecuteScriptAndExtractString(contents, kGetBodyClass, &result));
   EXPECT_EQ("dark serif", result);
+
+  // Test font scaling.
+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      contents, kGetFontSize, &result));
+  double oldFontSize;
+  base::StringToDouble(result, &oldFontSize);
+
+  const double kScale = 1.23;
+  distilled_page_prefs->SetFontScaling(kScale);
+  base::RunLoop().RunUntilIdle();
+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      contents, kGetFontSize, &result));
+  double fontSize;
+  base::StringToDouble(result, &fontSize);
+  ASSERT_FLOAT_EQ(kScale, fontSize/oldFontSize);
+}
+
+IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest, PrefPersist) {
+  expect_distillation_ = false;
+  expect_distiller_page_ = false;
+  const GURL url("chrome-distiller://bad");
+  ui_test_utils::NavigateToURL(browser(), url);
+  content::WebContents* contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  content::WaitForLoadStop(contents);
+
+  std::string result;
+  DistilledPagePrefs* distilled_page_prefs =
+       DomDistillerServiceFactory::GetForBrowserContext(
+            browser()->profile())->GetDistilledPagePrefs();
+
+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      contents, kGetFontSize, &result));
+  double oldFontSize;
+  base::StringToDouble(result, &oldFontSize);
+
+  // Set preference.
+  const double kScale = 1.23;
+  distilled_page_prefs->SetTheme(DistilledPagePrefs::DARK);
+  distilled_page_prefs->SetFontFamily(DistilledPagePrefs::SERIF);
+  distilled_page_prefs->SetFontScaling(kScale);
+
+  base::RunLoop().RunUntilIdle();
+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      contents, kGetBodyClass, &result));
+  EXPECT_EQ("dark serif", result);
+  EXPECT_EQ(kDarkToolbarThemeColor, contents->GetThemeColor());
+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      contents, kGetFontSize, &result));
+  double fontSize;
+  base::StringToDouble(result, &fontSize);
+  ASSERT_FLOAT_EQ(kScale, fontSize/oldFontSize);
+
+  // Make sure perf persist across web pages.
+  GURL url2("chrome-distiller://bad2");
+  ui_test_utils::NavigateToURL(browser(), url2);
+  content::WaitForLoadStop(contents);
+
+  base::RunLoop().RunUntilIdle();
+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      contents, kGetBodyClass, &result));
+  EXPECT_EQ("dark serif", result);
+  EXPECT_EQ(kDarkToolbarThemeColor, contents->GetThemeColor());
+
+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      contents, kGetFontSize, &result));
+  base::StringToDouble(result, &fontSize);
+  ASSERT_FLOAT_EQ(kScale, fontSize/oldFontSize);
 }
 
 }  // namespace dom_distiller