Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1225153003: Fix crash when toggling "Everything is awesome" in Stock's Settings. (Closed)

Created:
5 years, 5 months ago by Matt Perry
Modified:
5 years, 5 months ago
Reviewers:
Hixie, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix crash when toggling "Everything is awesome" in Stock's Settings. Material.backgroundColor can be null. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c0c0ef4639d95cfea00eab8729b332f18b9a867b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M sky/sdk/lib/widgets/material.dart View 2 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Matt Perry
5 years, 5 months ago (2015-07-09 23:24:17 UTC) #2
Hixie
lgtm
5 years, 5 months ago (2015-07-09 23:25:04 UTC) #3
Matt Perry
Committed patchset #1 (id:1) manually as c0c0ef4639d95cfea00eab8729b332f18b9a867b (presubmit successful).
5 years, 5 months ago (2015-07-09 23:28:47 UTC) #4
abarth-chromium
5 years, 5 months ago (2015-07-10 03:12:55 UTC) #6
Message was sent while issue was closed.
This caused tests to fail due to an analyzer error.  Fix in
https://codereview.chromium.org/1228273002

Notice the red try job result.

Powered by Google App Engine
This is Rietveld 408576698