Issue 1225153003: Fix crash when toggling "Everything is awesome" in Stock's Settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1225153003: Fix crash when toggling "Everything is awesome" in Stock's Settings. (Closed)

Created:
5 years, 5 months ago by Matt Perry

Modified:
5 years, 5 months ago

Reviewers:
Hixie, abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix crash when toggling "Everything is awesome" in Stock's Settings. Material.backgroundColor can be null. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c0c0ef4639d95cfea00eab8729b332f18b9a867b

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
	M	sky/sdk/lib/widgets/material.dart	View		2 chunks	+8 lines, -11 lines	0 comments	Download

Total messages: 6 (2 generated)

Matt Perry

Committed patchset #1 (id:1) manually as c0c0ef4639d95cfea00eab8729b332f18b9a867b (presubmit successful).

5 years, 5 months ago (2015-07-09 23:28:47 UTC) #4

abarth-chromium

5 years, 5 months ago (2015-07-10 03:12:55 UTC) #6

Message was sent while issue was closed.

This caused tests to fail due to an analyzer error.  Fix in
https://codereview.chromium.org/1228273002

Notice the red try job result.