Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 1225123005: Teach Widget some new tricks to enable build-during-layout. (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Teach Widget some new tricks to enable build-during-layout. There are basically three tricks here: - Making retainStatefulNodeIfPossible non-private, so that RenderObjectWrappers in other files can use it. - RenderObjectWrappers have a utility function that subclasses can call (retainStatefulRenderObjectWrapper()) to enable them to be retained, when they override retainStatefulNodeIfPossible. - enterLayoutCallbackBuilder()/exitLayoutCallbackBuilder() API to set the right flags so that you can build Widget nodes outside a regular build cycle Also: - Widget.toStringName(), for debugging when you don't want the whole subtree printed. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8bc81ace0c3b6d145e976424293a7bf0af1ea82c

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -24 lines) Patch
M sky/sdk/lib/widgets/widget.dart View 1 12 chunks +46 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-09 00:41:25 UTC) #2
Hixie
5 years, 5 months ago (2015-07-09 00:54:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8bc81ace0c3b6d145e976424293a7bf0af1ea82c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698