Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 12251009: Removing the menu entry to start the ash desktop in Windows. (Closed)

Created:
7 years, 10 months ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Removing the menu entry to start the ash desktop in Windows. Previouly we removed it from Win8 but it is really just something that is experimental and now that Aura is deployed we don't want the casual user to play with it. Accelerator entry is gone as well. The menu entry is kept in debug mode BUG=175036 TEST=menu entry is gone in canary, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182362

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M chrome/browser/ui/browser_command_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cpu_(ooo_6.6-7.5)
this is people don't play with what might burn them.
7 years, 10 months ago (2013-02-13 00:05:42 UTC) #1
sky
Can we leave it in debug builds? Also, what about the shortcut?
7 years, 10 months ago (2013-02-13 00:39:25 UTC) #2
cpu_(ooo_6.6-7.5)
ctrl+shift+a still works both in release and debug, you want the menu on debug?
7 years, 10 months ago (2013-02-13 03:05:12 UTC) #3
sky
Yes, menu on debug. I think the shortcut should be nuked in release builds too. ...
7 years, 10 months ago (2013-02-13 15:26:51 UTC) #4
cpu_(ooo_6.6-7.5)
sure thing. code changed please take a look again.
7 years, 10 months ago (2013-02-13 22:04:23 UTC) #5
sky
7 years, 10 months ago (2013-02-13 22:48:14 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698