chrome/browser/geolocation/geolocation_browsertest.cc - Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_browsertest.cc

Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_test_base

Patch Set: Comments from jhawkins, round two. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/geolocation/geolocation_browsertest.cc

diff --git a/chrome/browser/geolocation/geolocation_browsertest.cc b/chrome/browser/geolocation/geolocation_browsertest.cc

index 2e8923b0acaa7abc74e8dc87d05ee3db326979a9..4d7812ed93a653deea051a0ba45ca49a855c4606 100644

--- a/chrome/browser/geolocation/geolocation_browsertest.cc

+++ b/chrome/browser/geolocation/geolocation_browsertest.cc

@@ -291,8 +291,7 @@ bool GeolocationBrowserTest::Initialize(InitializationOptions options) {

current_url_ = embedded_test_server()->GetURL(html_for_tests_);

if (options == INITIALIZATION_OFFTHERECORD) {

- current_browser_ = ui_test_utils::OpenURLOffTheRecord(

- browser()->profile(), current_url_);

+ current_browser_ = OpenURLOffTheRecord(browser()->profile(), current_url_);

} else {

current_browser_ = browser();

if (options == INITIALIZATION_NEWTAB)

« no previous file with comments | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | chrome/browser/prefetch/prefetch_browsertest.cc » ('j') | no next file with comments »