chrome/browser/extensions/api/web_request/web_request_apitest.cc - Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_test_base

Patch Set: Comments from jhawkins, round two. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc ('k') | chrome/browser/extensions/extension_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

index 3201f0bd28479b832696f0b067dae0b074beed19..c9bdf6ea68ce89bec8ee0e35d104051a5b4ce06d 100644

--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

@@ -216,8 +216,8 @@ void ExtensionWebRequestApiTest::RunPermissionTest(

EXPECT_EQ(expected_content_regular_window, body);

// Test that navigation in OTR window is properly redirected.

- Browser* otr_browser = ui_test_utils::OpenURLOffTheRecord(

- browser()->profile(), GURL("about:blank"));

+ Browser* otr_browser =

+ OpenURLOffTheRecord(browser()->profile(), GURL("about:blank"));

if (wait_for_extension_loaded_in_incognito)

EXPECT_TRUE(listener_incognito.WaitUntilSatisfied());

@@ -307,7 +307,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, IncognitoSplitModeReload) {

test_data_dir_.AppendASCII("webrequest_reload"),

kFlagEnableIncognito);

ASSERT_TRUE(extension);

- ui_test_utils::OpenURLOffTheRecord(browser()->profile(), GURL("about:blank"));

+ OpenURLOffTheRecord(browser()->profile(), GURL("about:blank"));

EXPECT_TRUE(listener.WaitUntilSatisfied());

EXPECT_TRUE(listener_incognito.WaitUntilSatisfied());