chrome/browser/apps/app_browsertest.cc - Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_test_base

Patch Set: Comments from jhawkins, round two. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/app_browsertest.cc

diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc

index 422c547c6739d7acba4a7f688043202e7c9dc104..6bb8822d2f5796cd8769428028ff0877522e1bc3 100644

--- a/chrome/browser/apps/app_browsertest.cc

+++ b/chrome/browser/apps/app_browsertest.cc

@@ -812,10 +812,7 @@ void PlatformAppDevToolsBrowserTest::RunTestWithDevTools(

content::WebContents* web_contents = window->web_contents();

ASSERT_TRUE(web_contents);

- // Ensure no DevTools open for the AppWindow, then open one.

- ASSERT_FALSE(DevToolsAgentHost::HasFor(web_contents));

- DevToolsWindow::OpenDevToolsWindow(web_contents);

- ASSERT_TRUE(DevToolsAgentHost::HasFor(web_contents));

+ OpenDevToolsWindow(web_contents);

if (test_flags & RELAUNCH) {

// Close the AppWindow, and ensure it is gone.

« no previous file with comments | « no previous file | chrome/browser/extensions/api/cookies/cookies_apitest.cc » ('j') | no next file with comments »