chrome/browser/prefetch/prefetch_browsertest.cc - Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prefetch/prefetch_browsertest.cc

Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_test_base

Patch Set: Comments from jhawkins, round two. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_browsertest.cc ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "base/prefs/pref_service.h"	6 #include "base/prefs/pref_service.h"

7 #include "base/strings/utf_string_conversions.h"	7 #include "base/strings/utf_string_conversions.h"

8 #include "chrome/browser/net/prediction_options.h"	8 #include "chrome/browser/net/prediction_options.h"

9 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

10 #include "chrome/browser/ui/browser.h"	10 #include "chrome/browser/ui/browser.h"

(...skipping 127 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
138	138

139 // Bug 339909: When in incognito mode the browser crashed due to an	139 // Bug 339909: When in incognito mode the browser crashed due to an

140 // uninitialized preference member. Verify that it no longer does.	140 // uninitialized preference member. Verify that it no longer does.

141 IN_PROC_BROWSER_TEST_F(PrefetchBrowserTestPrediction, IncognitoTest) {	141 IN_PROC_BROWSER_TEST_F(PrefetchBrowserTestPrediction, IncognitoTest) {

142 Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();	142 Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();

143 Browser* incognito_browser = new Browser(	143 Browser* incognito_browser = new Browser(

144 Browser::CreateParams(incognito_profile, browser()->host_desktop_type()));	144 Browser::CreateParams(incognito_profile, browser()->host_desktop_type()));

145	145

146 // Navigate just to have a tab in this window, otherwise there is no	146 // Navigate just to have a tab in this window, otherwise there is no

147 // WebContents for the incognito browser.	147 // WebContents for the incognito browser.

148 ui_test_utils::OpenURLOffTheRecord(browser()->profile(), GURL("about:blank"));	148 OpenURLOffTheRecord(browser()->profile(), GURL("about:blank"));

149	149

150 EXPECT_TRUE(RunPrefetchExperiment(true, incognito_browser));	150 EXPECT_TRUE(RunPrefetchExperiment(true, incognito_browser));

151 }	151 }

152	152

153 } // namespace	153 } // namespace

OLD	NEW