Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Side by Side Diff: chrome/browser/extensions/api/cookies/cookies_apitest.cc

Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_test_base
Patch Set: Comments from jhawkins, round two. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "chrome/browser/extensions/extension_apitest.h" 6 #include "chrome/browser/extensions/extension_apitest.h"
7 #include "chrome/test/base/ui_test_utils.h" 7 #include "chrome/test/base/ui_test_utils.h"
8 8
9 namespace extensions { 9 namespace extensions {
10 10
11 // Times out on win syzyasan, http://crbug.com/166026 11 // Times out on win syzyasan, http://crbug.com/166026
12 #if defined(SYZYASAN) 12 #if defined(SYZYASAN)
13 #define MAYBE_Cookies DISABLED_Cookies 13 #define MAYBE_Cookies DISABLED_Cookies
14 #else 14 #else
15 #define MAYBE_Cookies Cookies 15 #define MAYBE_Cookies Cookies
16 #endif 16 #endif
17 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Cookies) { 17 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Cookies) {
18 ASSERT_TRUE(RunExtensionTest("cookies/api")) << message_; 18 ASSERT_TRUE(RunExtensionTest("cookies/api")) << message_;
19 } 19 }
20 20
21 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, CookiesEvents) { 21 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, CookiesEvents) {
22 ASSERT_TRUE(RunExtensionTest("cookies/events")) << message_; 22 ASSERT_TRUE(RunExtensionTest("cookies/events")) << message_;
23 } 23 }
24 24
25 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, CookiesEventsSpanning) { 25 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, CookiesEventsSpanning) {
26 // We need to initialize an incognito mode window in order have an initialized 26 // We need to initialize an incognito mode window in order have an initialized
27 // incognito cookie store. Otherwise, the chrome.cookies.set operation is just 27 // incognito cookie store. Otherwise, the chrome.cookies.set operation is just
28 // ignored and we won't be notified about a newly set cookie for which we want 28 // ignored and we won't be notified about a newly set cookie for which we want
29 // to test whether the storeId is set correctly. 29 // to test whether the storeId is set correctly.
30 ui_test_utils::OpenURLOffTheRecord(browser()->profile(), 30 OpenURLOffTheRecord(browser()->profile(), GURL("chrome://newtab/"));
31 GURL("chrome://newtab/"));
32 ASSERT_TRUE(RunExtensionTestIncognito("cookies/events_spanning")) << message_; 31 ASSERT_TRUE(RunExtensionTestIncognito("cookies/events_spanning")) << message_;
33 } 32 }
34 33
35 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, CookiesNoPermission) { 34 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, CookiesNoPermission) {
36 ASSERT_TRUE(RunExtensionTest("cookies/no_permission")) << message_; 35 ASSERT_TRUE(RunExtensionTest("cookies/no_permission")) << message_;
37 } 36 }
38 37
39 } // namespace extensions 38 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/extensions/api/extension_action/browser_action_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698