Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Issue 1225093002: Re-enable ScreenOrientationBrowserTests on Chrome OS (Closed)

Created:
5 years, 5 months ago by jonross
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-screen-orientation_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable ScreenOrientationBrowserTests on Chrome OS Two tests were flaking on Chrome OS builds. Re-enabling to confirm that fixes to Screen Orientation API also fixed these tests. TEST=ScreenOrientationBrowserTest.ScreenOrientationChange, ScreenOrientationBrowserTest.WindowOrientationChange BUG=468259 Committed: https://crrev.com/4fa07d46cbdea4b263ad07beca29f90b42757c67 Cr-Commit-Position: refs/heads/master@{#337950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M content/browser/screen_orientation/screen_orientation_browsertest.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jonross
Hey Mounir, I tried re-enabling these tests locally. All ran fine. Trybots for CrOS also ...
5 years, 5 months ago (2015-07-08 22:09:35 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years, 5 months ago (2015-07-08 22:15:10 UTC) #4
mlamouri (slow - plz ping)
On 2015/07/08 at 22:15:10, Mounir Lamouri wrote: > lgtm Thanks! :)
5 years, 5 months ago (2015-07-08 22:15:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225093002/1
5 years, 5 months ago (2015-07-08 22:15:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 00:22:31 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4fa07d46cbdea4b263ad07beca29f90b42757c67 Cr-Commit-Position: refs/heads/master@{#337950}
5 years, 5 months ago (2015-07-09 00:24:39 UTC) #8
Mattias Nissler (ping if slow)
5 years, 5 months ago (2015-07-09 10:03:22 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1227163004/ by mnissler@chromium.org.

The reason for reverting is: Unfortunately, the tests still flake a lot:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

Powered by Google App Engine
This is Rietveld 408576698