Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: content/browser/loader/resource_dispatcher_host_browsertest.cc

Issue 1225083002: media: Add BrowserCdmManagerProcessWatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment and fix "override" Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ref_counted.h" 5 #include "base/memory/ref_counted.h"
6 #include "base/strings/string_util.h" 6 #include "base/strings/string_util.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "content/browser/download/download_manager_impl.h" 9 #include "content/browser/download/download_manager_impl.h"
10 #include "content/browser/web_contents/web_contents_impl.h" 10 #include "content/browser/web_contents/web_contents_impl.h"
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 } 298 }
299 299
300 // Tests that the onbeforeunload and onunload logic is short-circuited if the 300 // Tests that the onbeforeunload and onunload logic is short-circuited if the
301 // old renderer is gone. In that case, we don't want to wait for the old 301 // old renderer is gone. In that case, we don't want to wait for the old
302 // renderer to run the handlers. 302 // renderer to run the handlers.
303 // We need to disable this on Mac because the crash causes the OS CrashReporter 303 // We need to disable this on Mac because the crash causes the OS CrashReporter
304 // process to kick in to analyze the poor dead renderer. Unfortunately, if the 304 // process to kick in to analyze the poor dead renderer. Unfortunately, if the
305 // app isn't stripped of debug symbols, this takes about five minutes to 305 // app isn't stripped of debug symbols, this takes about five minutes to
306 // complete and isn't conducive to quick turnarounds. As we don't currently 306 // complete and isn't conducive to quick turnarounds. As we don't currently
307 // strip the app on the build bots, this is bad times. 307 // strip the app on the build bots, this is bad times.
308 // Also disabled on Android (http://crbug.com/506188). 308 #if defined(OS_MACOSX)
309 #if defined(OS_MACOSX) || defined(OS_ANDROID)
310 #define MAYBE_CrossSiteAfterCrash DISABLED_CrossSiteAfterCrash 309 #define MAYBE_CrossSiteAfterCrash DISABLED_CrossSiteAfterCrash
311 #else 310 #else
312 #define MAYBE_CrossSiteAfterCrash CrossSiteAfterCrash 311 #define MAYBE_CrossSiteAfterCrash CrossSiteAfterCrash
313 #endif 312 #endif
314 IN_PROC_BROWSER_TEST_F(ResourceDispatcherHostBrowserTest, 313 IN_PROC_BROWSER_TEST_F(ResourceDispatcherHostBrowserTest,
315 MAYBE_CrossSiteAfterCrash) { 314 MAYBE_CrossSiteAfterCrash) {
316 // Make sure we have a live process before trying to kill it. 315 // Make sure we have a live process before trying to kill it.
317 NavigateToURL(shell(), GURL("about:blank")); 316 NavigateToURL(shell(), GURL("about:blank"));
318 317
319 // Cause the renderer to crash. 318 // Cause the renderer to crash.
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
517 NavigateToURLBlockUntilNavigationsComplete( 516 NavigateToURLBlockUntilNavigationsComplete(
518 shell(), 517 shell(),
519 embedded_test_server()->GetURL("/client_redirect.html"), 518 embedded_test_server()->GetURL("/client_redirect.html"),
520 2); 519 2);
521 520
522 EXPECT_TRUE( 521 EXPECT_TRUE(
523 delegate.page_transition() & ui::PAGE_TRANSITION_CLIENT_REDIRECT); 522 delegate.page_transition() & ui::PAGE_TRANSITION_CLIENT_REDIRECT);
524 } 523 }
525 524
526 } // namespace content 525 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/media/cdm/browser_cdm_manager.cc » ('j') | content/browser/media/cdm/browser_cdm_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698