Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1225053003: Remove another assertion that a reference is non-null. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove another assertion that a reference is non-null. This tickles a warning in Clang: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] BUG=none Committed: https://skia.googlesource.com/skia/+/3ba043f460a5d60a7fd733f4109132fa79148559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ports/SkFontHost_win.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dcheng
5 years, 5 months ago (2015-07-08 20:10:49 UTC) #2
mtklein
lgtm
5 years, 5 months ago (2015-07-08 20:17:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225053003/1
5 years, 5 months ago (2015-07-08 20:17:30 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 20:25:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3ba043f460a5d60a7fd733f4109132fa79148559

Powered by Google App Engine
This is Rietveld 408576698