Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 12250031: Findbugs fix, rename TouchUtils (Closed)

Created:
7 years, 10 months ago by Kristian Monsen
Modified:
7 years, 9 months ago
Reviewers:
bulach
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android findbugs fix: rename TouchUtils to not shadow superclass This is the first patch, adding a new class that doesn't shadow the name of the super class. Next patch will remove the old class after all usage of the old class is removed in other repositories. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183349

Patch Set 1 #

Patch Set 2 : Renamed to TestTouchUtil #

Patch Set 3 : Rebaseline #

Patch Set 4 : Reword patch description #

Patch Set 5 : Removing not used class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -217 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchUtils.java View 3 4 1 chunk +0 lines, -216 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Kristian Monsen
If you have a better name, I'm happy to update.
7 years, 10 months ago (2013-02-13 06:00:52 UTC) #1
bulach
maybe TestTouchUtils? not sure if any better... note though that there are a hundreds of ...
7 years, 10 months ago (2013-02-13 11:49:15 UTC) #2
Kristian Monsen
On 2013/02/13 11:49:15, bulach wrote: > maybe TestTouchUtils? not sure if any better... > > ...
7 years, 10 months ago (2013-02-14 01:29:35 UTC) #3
Kristian Monsen
Updated to keep the old file, and updated the name, PTAL.
7 years, 10 months ago (2013-02-14 16:39:45 UTC) #4
bulach
lgtm, just make the try bots happy :) btw, the description could be a bit ...
7 years, 10 months ago (2013-02-14 16:50:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/12250031/12001
7 years, 10 months ago (2013-02-19 22:54:53 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 01:05:34 UTC) #7
Message was sent while issue was closed.
Change committed as 183349

Powered by Google App Engine
This is Rietveld 408576698