Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: remoting/webapp/server_log_entry.js

Issue 12250011: Get extension version synchrously from the manifest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reviewer comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/remoting.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/server_log_entry.js
diff --git a/remoting/webapp/server_log_entry.js b/remoting/webapp/server_log_entry.js
index 18dc6c3599ea5ead5b2299eec554fa6ff4a6d1e6..e0b6dc37c9387dc7e2ac790e26a6a95d3bbb0935 100644
--- a/remoting/webapp/server_log_entry.js
+++ b/remoting/webapp/server_log_entry.js
@@ -451,8 +451,10 @@ remoting.ServerLogEntry.extractChromeVersionFrom = function(s) {
* Adds a field specifying the webapp version to this log entry.
*/
remoting.ServerLogEntry.prototype.addWebappVersionField = function() {
- this.set(remoting.ServerLogEntry.KEY_WEBAPP_VERSION_,
- chrome.app.getDetails().version);
+ var manifest = chrome.runtime.getManifest();
+ if (manifest && manifest.version) {
+ this.set(remoting.ServerLogEntry.KEY_WEBAPP_VERSION_, manifest.version);
+ }
};
/**
« no previous file with comments | « remoting/webapp/remoting.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698