Get extension version synchrously from the manifest.

remoting/webapp/remoting.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /** @type {remoting.HostSession} */ remoting.hostSession = null;
@@ skipping 31 matching lines @@
 };
 
 /**
  * Entry point for app initialization.
  */
 remoting.init = function() {
   // TODO(jamiewalch): Remove this when we migrate to apps v2
   // (http://crbug.com/ 134213).
   remoting.initMockStorage();
 
-  remoting.logExtensionInfoAsync_();
+  remoting.logExtensionInfo_();
   l10n.localize();
   // Create global objects.
   remoting.settings = new remoting.Settings();
   remoting.oauth2 = new remoting.OAuth2();
   // TODO(jamiewalch): Reinstate this when we migrate to apps v2
   // (http://crbug.com/ 134213).
   // remoting.identity = new remoting.Identity(consentRequired_);
   remoting.identity = remoting.oauth2;
   remoting.stats = new remoting.ConnectionStats(
       document.getElementById('statistics'));
@@ skipping 96 matching lines @@
    */
   var onHostState = function(state, localHostId) {
     remoting.hostList.setLocalHostStateAndId(state, localHostId);
     remoting.hostList.display();
   };
   remoting.hostController.getLocalHostStateAndId(onHostState);
 };
 
 /**
  * Log information about the current extension.
- * The extension manifest is loaded and parsed to extract this info.
+ * The extension manifest is parsed to extract this info.
  */
-remoting.logExtensionInfoAsync_ = function() {
-  /** @type {XMLHttpRequest} */
-  var xhr = new XMLHttpRequest();
-  xhr.open('GET', 'manifest.json');
-  xhr.onload = function(e) {
-    var manifest =
-        /** @type {{name: string, version: string, default_locale: string}} */
-        jsonParseSafe(xhr.responseText);
-    if (manifest) {
-      var name = chrome.i18n.getMessage('PRODUCT_NAME');
-      console.log(name + ' version: ' + manifest.version);
-    } else {
-      console.error('Failed to get product version. Corrupt manifest?');
-    }
+remoting.logExtensionInfo_ = function() {
+  var manifest = chrome.runtime.getManifest();
+  if (manifest.version) {

[garykac, 2013/02/12 21:08:37]

does this need to be (manifest && manifest.version)?

[Jamie, 2013/02/12 22:04:21]

The documentation doesn't say that getManifest can return NULL, but it can't
hurt. I've fixed it here and in the other place.

+    var name = chrome.i18n.getMessage('PRODUCT_NAME');
+    console.log(name + ' version: ' + manifest.version);
+  } else {
+    console.error('Failed to get product version. Corrupt manifest?');
   }
-  xhr.send(null);
 };
 
 /**
  * If an IT2Me client or host is active then prompt the user before closing.
  * If a Me2Me client is active then don't bother, since closing the window is
  * the more intuitive way to end a Me2Me session, and re-connecting is easy.
  *
  * @return {?string} The prompt string if a connection is active.
  */
 remoting.promptClose = function() {
@@ skipping 171 matching lines @@
   /** @param {chrome.Tab} tab The current tab. */
   var tabCallback = function(tab) {
     if (tab.pinned) {
       callback(remoting.TabType.PINNED);
     } else {
       chrome.windows.get(tab.windowId, null, windowCallback);
     }
   };
   chrome.tabs.getCurrent(tabCallback);
 }