Issue 12250011: Get extension version synchrously from the manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12250011: Get extension version synchrously from the manifest. (Closed)

Created:
7 years, 10 months ago by Jamie

Modified:
7 years, 10 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get extension version synchrously from the manifest. Previously, we were asynchronously reading the manifest at start-up and using chrome.runtime.getDetails when logging the version string. The latter is more complicated than it needs to be, and the former doesn't work in Apps v2. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182036

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reviewer comments. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -20 lines)			Patch
M	remoting/webapp/jscompiler_hacks.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	remoting/webapp/remoting.js	View	1	2 chunks	+9 lines, -17 lines	0 comments	Download
M	remoting/webapp/server_log_entry.js	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

garykac

lgtm https://codereview.chromium.org/12250011/diff/1/remoting/webapp/remoting.js File remoting/webapp/remoting.js (right): https://codereview.chromium.org/12250011/diff/1/remoting/webapp/remoting.js#newcode173 remoting/webapp/remoting.js:173: if (manifest.version) { does this need to be ...

7 years, 10 months ago (2013-02-12 21:08:37 UTC) #2

Jamie

7 years, 10 months ago (2013-02-12 22:04:21 UTC) #3

FYI

https://codereview.chromium.org/12250011/diff/1/remoting/webapp/remoting.js
File remoting/webapp/remoting.js (right):

https://codereview.chromium.org/12250011/diff/1/remoting/webapp/remoting.js#n...
remoting/webapp/remoting.js:173: if (manifest.version) {
On 2013/02/12 21:08:37, garykac wrote:
> does this need to be (manifest && manifest.version)?

The documentation doesn't say that getManifest can return NULL, but it can't
hurt. I've fixed it here and in the other place.

Expand Messages | Collapse Messages