Issue 12250008: Cleanup: Remove more uses of deprecated PrintPreviewDialogController methods.

Issue 12250008: Cleanup: Remove more uses of deprecated PrintPreviewDialogController methods. (Closed)

Created:
7 years, 10 months ago by Lei Zhang

Modified:
7 years, 10 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cleanup: Remove more uses of deprecated PrintPreviewDialogController methods. BUG=163671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182099

Patch Set 2 : fix test #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -173 lines)			Patch
M	chrome/browser/printing/print_preview_dialog_controller.h	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/printing/print_preview_dialog_controller.cc	View		5 chunks	+20 lines, -35 lines	0 comments	Download
M	chrome/browser/printing/print_preview_dialog_controller_browsertest.cc	View		4 chunks	+22 lines, -21 lines	0 comments	Download
M	chrome/browser/printing/print_preview_dialog_controller_unittest.cc	View	1	3 chunks	+93 lines, -80 lines	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.cc	View		2 chunks	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/base/test_tab_strip_model_observer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/test_tab_strip_model_observer.cc	View		1 chunk	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

lgtm https://codereview.chromium.org/12250008/diff/7001/chrome/browser/printing/print_preview_dialog_controller.cc File chrome/browser/printing/print_preview_dialog_controller.cc (right): https://codereview.chromium.org/12250008/diff/7001/chrome/browser/printing/print_preview_dialog_controller.cc#newcode252 chrome/browser/printing/print_preview_dialog_controller.cc:252: // If |contents| is an initiator tab. I ...

7 years, 10 months ago (2013-02-12 19:45:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12250008/7001

7 years, 10 months ago (2013-02-12 19:46:24 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98950

7 years, 10 months ago (2013-02-12 20:34:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12250008/13003

7 years, 10 months ago (2013-02-12 21:07:17 UTC) #6

Message was sent while issue was closed.

Change committed as 182099

Expand Messages | Collapse Messages