Issue 12250005: Pass /nomitag to GoogleUpdateSetup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12250005: Pass /nomitag to GoogleUpdateSetup. (Closed)

Created:
7 years, 10 months ago by erikwright (departed)

Modified:
7 years, 10 months ago

Reviewers:
grt (UTC plus 2)

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pass /nomitag to GoogleUpdateSetup to ignore meta-installer tags. This allows user-level activation of Google Update from a cached system-level GoogleUpdateSetup.exe, even if the latter is a tagged meta installer. R=grt@chromium.org BUG=175028 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182048

Patch Set 1 #

Total comments: 2

Patch Set 2 : Pass /nomitag to GoogleUpdateSetup. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/installer/util/google_update_util.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

grt (UTC plus 2)

lgtm w/ two nits. has the google update team sanctioned this, by any chance? https://codereview.chromium.org/12250005/diff/1/chrome/installer/util/google_update_util.cc ...

7 years, 10 months ago (2013-02-12 18:31:55 UTC) #2

erikwright (departed)

PTAL. This is the solution from omaha-support.

7 years, 10 months ago (2013-02-12 19:26:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/12250005/5001

7 years, 10 months ago (2013-02-12 19:53:22 UTC) #5

Message was sent while issue was closed.

Change committed as 182048

Expand Messages | Collapse Messages