Source/core/paint/SVGContainerPainter.cpp - Issue 1224933002: Combine outline and focus ring code paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/SVGContainerPainter.cpp

Issue 1224933002: Combine outline and focus ring code paths (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix empty focus ring on Mac Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/paint/SVGContainerPainter.cpp

diff --git a/Source/core/paint/SVGContainerPainter.cpp b/Source/core/paint/SVGContainerPainter.cpp

index 9f90c5aa572c34f8f47e848477b789013110d14f..b382fbaa977e724561b31055662388034b0fa945 100644

--- a/Source/core/paint/SVGContainerPainter.cpp

+++ b/Source/core/paint/SVGContainerPainter.cpp

@@ -61,8 +61,7 @@ void SVGContainerPainter::paint(const PaintInfo& paintInfo)

if (m_layoutSVGContainer.style()->outlineWidth() && m_layoutSVGContainer.style()->visibility() == VISIBLE) {

PaintInfo outlinePaintInfo(paintInfoBeforeFiltering);

outlinePaintInfo.phase = PaintPhaseSelfOutline;

- LayoutRect layoutBoundingBox(boundingBox);

- ObjectPainter(m_layoutSVGContainer).paintOutline(outlinePaintInfo, m_layoutSVGContainer.outlineVisualOverflowRect(), layoutBoundingBox.size(), layoutBoundingBox.location());

+ ObjectPainter(m_layoutSVGContainer).paintOutline(outlinePaintInfo, LayoutPoint(boundingBox.location()));

}

if (paintInfoBeforeFiltering.isPrinting())

« no previous file with comments | « Source/core/paint/ReplacedPainter.cpp ('k') | Source/core/paint/SVGImagePainter.cpp » ('j') | no next file with comments »