Source/core/paint/ImagePainter.cpp - Issue 1224933002: Combine outline and focus ring code paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/ImagePainter.cpp

Issue 1224933002: Combine outline and focus ring code paths (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix empty focus ring on Mac Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/paint/ImagePainter.cpp

diff --git a/Source/core/paint/ImagePainter.cpp b/Source/core/paint/ImagePainter.cpp

index 41843b2a01b6d1aa3c52cb2a4b8930dbc489fa48..1639a716cb15645be5a631fa1ac7ff5e8bda7338 100644

--- a/Source/core/paint/ImagePainter.cpp

+++ b/Source/core/paint/ImagePainter.cpp

@@ -33,6 +33,8 @@ void ImagePainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOff

void ImagePainter::paintAreaElementFocusRing(const PaintInfo& paintInfo)

{

+ // TODO(wangxianzhu): In other places, we just paint focus ring if outline style is auto.

+ // We should also do that here to keep consistency.

Document& document = m_layoutImage.document();

if (paintInfo.isPrinting() || !document.frame()->selection().isFocusedAndActive())