Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Unified Diff: Source/core/paint/SVGContainerPainter.cpp

Issue 1224933002: Combine outline and focus ring code paths (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/SVGContainerPainter.cpp
diff --git a/Source/core/paint/SVGContainerPainter.cpp b/Source/core/paint/SVGContainerPainter.cpp
index 9f90c5aa572c34f8f47e848477b789013110d14f..abbea8cc71671e2396ec9872a6f61d635d6429c9 100644
--- a/Source/core/paint/SVGContainerPainter.cpp
+++ b/Source/core/paint/SVGContainerPainter.cpp
@@ -58,12 +58,8 @@ void SVGContainerPainter::paint(const PaintInfo& paintInfo)
if (paintInfoBeforeFiltering.phase != PaintPhaseForeground)
return;
- if (m_layoutSVGContainer.style()->outlineWidth() && m_layoutSVGContainer.style()->visibility() == VISIBLE) {
- PaintInfo outlinePaintInfo(paintInfoBeforeFiltering);
- outlinePaintInfo.phase = PaintPhaseSelfOutline;
- LayoutRect layoutBoundingBox(boundingBox);
- ObjectPainter(m_layoutSVGContainer).paintOutline(outlinePaintInfo, m_layoutSVGContainer.outlineVisualOverflowRect(), layoutBoundingBox.size(), layoutBoundingBox.location());
pdr. 2015/08/27 22:59:33 We can remove LayoutSVGModelObject::outlineVisualO
Xianzhu 2015/08/28 00:26:04 Done.
- }
+ if (m_layoutSVGContainer.style()->outlineWidth() && m_layoutSVGContainer.style()->visibility() == VISIBLE)
+ ObjectPainter(m_layoutSVGContainer).paintOutline(paintInfoBeforeFiltering, LayoutPoint(boundingBox.location()));
if (paintInfoBeforeFiltering.isPrinting())
ObjectPainter(m_layoutSVGContainer).addPDFURLRectIfNeeded(paintInfoBeforeFiltering, LayoutPoint());

Powered by Google App Engine
This is Rietveld 408576698