Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: Source/core/paint/ImagePainter.cpp

Issue 1224933002: Combine outline and focus ring code paths (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/ImagePainter.cpp
diff --git a/Source/core/paint/ImagePainter.cpp b/Source/core/paint/ImagePainter.cpp
index 41843b2a01b6d1aa3c52cb2a4b8930dbc489fa48..1639a716cb15645be5a631fa1ac7ff5e8bda7338 100644
--- a/Source/core/paint/ImagePainter.cpp
+++ b/Source/core/paint/ImagePainter.cpp
@@ -33,6 +33,8 @@ void ImagePainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOff
void ImagePainter::paintAreaElementFocusRing(const PaintInfo& paintInfo)
{
+ // TODO(wangxianzhu): In other places, we just paint focus ring if outline style is auto.
+ // We should also do that here to keep consistency.
Document& document = m_layoutImage.document();
if (paintInfo.isPrinting() || !document.frame()->selection().isFocusedAndActive())

Powered by Google App Engine
This is Rietveld 408576698