Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1224933002: Combine outline and focus ring code paths (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutObject.cpp
diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp
index 50aee305bd11df4acea16886236ff557663ecec2..1314d92687060d97a067f14ade32c61d9543f138 100644
--- a/Source/core/layout/LayoutObject.cpp
+++ b/Source/core/layout/LayoutObject.cpp
@@ -1403,11 +1403,10 @@ PaintInvalidationReason LayoutObject::paintInvalidationReason(const LayoutBoxMod
if (shouldDoFullPaintInvalidation())
return m_bitfields.fullPaintInvalidationReason();
- // The focus ring may change because of position change of descendants. For simplicity,
+ // The outline may change shape because of position change of descendants. For simplicity,
// just force full paint invalidation if this object is marked for checking paint invalidation
// for any reason.
- // TODO(wangxianzhu): extend this to all outlines.
- if (styleRef().outlineStyleIsAuto())
+ if (styleRef().hasOutline())
return PaintInvalidationOutline;
// If the bounds are the same then we know that none of the statements below

Powered by Google App Engine
This is Rietveld 408576698