Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: Source/core/layout/svg/LayoutSVGModelObject.h

Issue 1224933002: Combine outline and focus ring code paths (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix empty focus ring on Mac Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutObject.cpp ('k') | Source/core/layout/svg/LayoutSVGModelObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2009, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 void mapLocalToContainer(const LayoutBoxModelObject* paintInvalidationContai ner, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = nullptr, const PaintInvalidationState* = nullptr) const final; 57 void mapLocalToContainer(const LayoutBoxModelObject* paintInvalidationContai ner, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = nullptr, const PaintInvalidationState* = nullptr) const final;
58 const LayoutObject* pushMappingToContainer(const LayoutBoxModelObject* ances torToStopAt, LayoutGeometryMap&) const final; 58 const LayoutObject* pushMappingToContainer(const LayoutBoxModelObject* ances torToStopAt, LayoutGeometryMap&) const final;
59 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ; 59 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ;
60 60
61 void computeLayerHitTestRects(LayerHitTestRects&) const final; 61 void computeLayerHitTestRects(LayerHitTestRects&) const final;
62 62
63 SVGElement* element() const { return toSVGElement(LayoutObject::node()); } 63 SVGElement* element() const { return toSVGElement(LayoutObject::node()); }
64 64
65 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVG || LayoutObject::isOfType(type); } 65 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVG || LayoutObject::isOfType(type); }
66 66
67 // TODO(pdr): The outline extent should be included in paintInvalidationRect InLocalCoordinates.
68 // Returns the paint invalidation size inflated for the outline extent.
69 LayoutRect outlineVisualOverflowRect() const;
70
71 protected: 67 protected:
72 void addLayerHitTestRects(LayerHitTestRects&, const DeprecatedPaintLayer* cu rrentCompositedLayer, const LayoutPoint& layerOffset, const LayoutRect& containe rRect) const final; 68 void addLayerHitTestRects(LayerHitTestRects&, const DeprecatedPaintLayer* cu rrentCompositedLayer, const LayoutPoint& layerOffset, const LayoutRect& containe rRect) const final;
73 void willBeDestroyed() override; 69 void willBeDestroyed() override;
74 70
75 private: 71 private:
76 // LayoutSVGModelObject subclasses should use element() instead. 72 // LayoutSVGModelObject subclasses should use element() instead.
77 void node() const = delete; 73 void node() const = delete;
78 74
79 // This method should never be called, SVG uses a different nodeAtPoint meth od 75 // This method should never be called, SVG uses a different nodeAtPoint meth od
80 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) final; 76 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) final;
81 IntRect absoluteOutlineBoundingBoxRect() const final; 77 IntRect absoluteOutlineBoundingBoxRect() const final;
82 78
83 void invalidateTreeIfNeeded(PaintInvalidationState&) final; 79 void invalidateTreeIfNeeded(PaintInvalidationState&) final;
84 80
85 protected: 81 protected:
86 FloatRect m_paintInvalidationBoundingBox; 82 FloatRect m_paintInvalidationBoundingBox;
87 }; 83 };
88 84
89 } 85 }
90 86
91 #endif 87 #endif
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutObject.cpp ('k') | Source/core/layout/svg/LayoutSVGModelObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698