Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issue 1224923003: Move and rename CmaMessageLoop to chromecast/media/base/MediaMessageLoop (Closed)

Created:
5 years, 5 months ago by halliwell
Modified:
5 years, 5 months ago
Reviewers:
lcwu1, gunsch
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, gunsch+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CmaMessageLoop chromecast/browser/media -> chromecast/media/base and rename as MediaMessageLoop This is to make adding it as a dependency of Cast ozone platform more palatable, see first patchset of https://codereview.chromium.org/1223793009/. BUG=469374 Committed: https://crrev.com/3975e4f810292468254b0901e9a564e1a373ec59 Cr-Commit-Position: refs/heads/master@{#337814}

Patch Set 1 #

Patch Set 2 : Rename to MediaMessageLoop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -100 lines) Patch
M chromecast/browser/media/cast_browser_cdm_factory.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chromecast/browser/media/cma_message_filter_host.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
D chromecast/browser/media/cma_message_loop.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chromecast/browser/media/cma_message_loop.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/media/base/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + chromecast/media/base/media_message_loop.h View 1 2 chunks +10 lines, -10 lines 0 comments Download
A + chromecast/media/base/media_message_loop.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chromecast/media/media.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
halliwell
5 years, 5 months ago (2015-07-07 17:11:06 UTC) #2
gunsch
Thought: do we want to rename it while we move? e.g. MediaMessageLoop vs. CmaMessageLoop, since ...
5 years, 5 months ago (2015-07-07 17:49:12 UTC) #3
halliwell
On 2015/07/07 17:49:12, gunsch wrote: > Thought: do we want to rename it while we ...
5 years, 5 months ago (2015-07-07 18:04:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224923003/20001
5 years, 5 months ago (2015-07-07 18:40:02 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-07 19:17:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224923003/20001
5 years, 5 months ago (2015-07-07 22:01:54 UTC) #11
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-07-08 00:25:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224923003/20001
5 years, 5 months ago (2015-07-08 14:24:32 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-08 14:28:30 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 14:29:25 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3975e4f810292468254b0901e9a564e1a373ec59
Cr-Commit-Position: refs/heads/master@{#337814}

Powered by Google App Engine
This is Rietveld 408576698