appengine/config_service/storage_test.py - Issue 1224913002: luci-config: fine-grained acls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/config_service/storage_test.py

Issue 1224913002: luci-config: fine-grained acls (Closed) Base URL: git@github.com:luci/luci-py.git@master

Patch Set: fine-grained acls for service configs Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/config_service/storage_test.py

diff --git a/appengine/config_service/storage_test.py b/appengine/config_service/storage_test.py

index f07924ccea616907e4526c330d055e20f10e1149..4d2d807d979f4367c8c59877a1cf8c4ea9e25f64 100755

--- a/appengine/config_service/storage_test.py

+++ b/appengine/config_service/storage_test.py

@@ -148,14 +148,14 @@ class StorageTestCase(test_case.TestCase):

self.assertEqual(msg.gitiles.fetch_log_deadline, 42)

def test_get_self_config(self):

- expected = service_config_pb2.AclCfg(service_access_group='group')

+ expected = service_config_pb2.AclCfg(project_access_group='group')

self.mock(storage, 'get_config_hash_async', mock.Mock())

self.mock(storage, 'get_config_by_hash_async', mock.Mock())

storage.get_config_hash_async.return_value = future(

('deadbeef', 'beefdead'))

storage.get_config_by_hash_async.return_value = future(

- 'service_access_group: "group"')

+ 'project_access_group: "group"')

actual = storage.get_self_config_async(

'acl.cfg', service_config_pb2.AclCfg).get_result()