luci-config: fine-grained acls

appengine/components/components/config/validation_test.py

 #!/usr/bin/env python
 # Copyright 2015 The Swarming Authors. All rights reserved.
 # Use of this source code is governed by the Apache v2.0 license that can be
 # found in the LICENSE file.
 
 import logging
 import re
 import sys
 import unittest
 import yaml
@@ skipping 26 matching lines @@
     self.assertEqual(validating_func.call_count, 1)
 
     validating_func.side_effect = lambda cfg, ctx: ctx.error('bad')
     with self.assertRaises(ValueError):
       self.rule_set.validate('projects/foo', 'bar.cfg', 'param: "valid config"')
 
     # Different config_set/path
     self.rule_set.validate('projects/foo', 'baz.cfg', 'wrong')
     self.rule_set.validate('projects/baz', 'bar.cfg', 'wrong')
 
+  def test_patterns(self):
+    validation.rule(
+        'projects/foo', 'bar.cfg', test_config_pb2.Config,
+        rule_set=self.rule_set)
+    validation.rule(
+        'services/foo', 'foo.cfg', test_config_pb2.Config,
+        rule_set=self.rule_set)
+    validation.rule(
+        'services/foo', 'foo.cfg', test_config_pb2.Config,
+        rule_set=self.rule_set)
+    self.assertEqual(
+      self.rule_set.patterns(),
+      {
+        validation.ConfigPattern('projects/foo', 'bar.cfg'),
+        validation.ConfigPattern('services/foo', 'foo.cfg'),
+        validation.ConfigPattern('services/foo', 'foo.cfg'),
+      }
+    )
+
   def test_context_metadata(self):
     ctx = validation.Context()
 
     ctx.config_set = 'services/foo'
     self.assertEqual(ctx.service_id, 'foo')
     self.assertEqual(ctx.project_id, None)
     self.assertEqual(ctx.ref, None)
 
     ctx.config_set = 'projects/foo'
     self.assertEqual(ctx.service_id, None)
     self.assertEqual(ctx.project_id, 'foo')
     self.assertEqual(ctx.ref, None)
 
     ctx.config_set = 'projects/foo/refs/a'
     self.assertEqual(ctx.service_id, None)
     self.assertEqual(ctx.project_id, 'foo')
     self.assertEqual(ctx.ref, 'refs/a')
 
   def test_regex_pattern_and_no_dest_type(self):
     rule = validation.rule(
-        config_set=re.compile('^projects/f[^/]+$').match,
-        path=lambda p: p.endswith('.yaml'),
+        config_set='regex:projects/f[^/]+',
+        path='regex:.+.yaml',
         rule_set=self.rule_set)
     def validate_yaml(cfg, ctx):
       try:
         yaml.safe_load(cfg)
       except Exception as ex:
         ctx.error(ex)
     rule(validate_yaml)
 
     self.rule_set.validate('projects/foo', 'bar.cfg', '}{')
     self.rule_set.validate('projects/bar', 'bar.yaml', '}{')
@@ skipping 33 matching lines @@
     rule = validation.rule(
         'projects/foo', 'bar.cfg', test_config_pb2.Config,
         rule_set=self.rule_set)
 
     with self.assertRaises(ValueError):
       self.rule_set.validate('projects/foo', 'bar.cfg', 'invalid config')
 
     rule.remove()
     self.rule_set.validate('projects/foo', 'bar.cfg', 'invalid config')
 
+  def test_compile_pattern(self):
+    self.assertTrue(validation.compile_pattern('abc')('abc'))
+    self.assertTrue(validation.compile_pattern('text:abc')('abc'))
+    self.assertFalse(validation.compile_pattern('text:abc')('abcd'))
+
+    self.assertTrue(validation.compile_pattern('regex:abc')('abc'))
+    self.assertTrue(validation.compile_pattern('regex:\w+')('abc'))
+    self.assertTrue(validation.compile_pattern('regex:^(\w+)c$')('abc'))
+    self.assertFalse(validation.compile_pattern('regex:\d+')('a123b'))
+
 
 if __name__ == '__main__':
   if '-v' in sys.argv:
     unittest.TestCase.maxDiff = None
   unittest.main()