Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 12249003: content: convert SSL notifications to observer usage (take 2) (Closed)

Created:
7 years, 10 months ago by Paweł Hajdan Jr.
Modified:
7 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

content: convert SSL notifications to observer usage (take 2) This is a resubmit of https://codereview.chromium.org/12041059 BUG=175308, 170921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182187

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -90 lines) Patch
M chrome/browser/ssl/ssl_blocking_page.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_tab_helper.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_tab_helper.cc View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +8 lines, -15 lines 0 comments Download
M content/browser/ssl/ssl_manager.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/ssl/ssl_manager.cc View 9 chunks +54 lines, -27 lines 0 comments Download
M content/browser/ssl/ssl_policy_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 3 chunks +9 lines, -2 lines 0 comments Download
M content/public/browser/notification_types.h View 1 chunk +0 lines, -34 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
I've added a NULL check in ssl_blocking_page.cc, so this should fix the crash, but I ...
7 years, 10 months ago (2013-02-12 11:41:17 UTC) #1
jam
7 years, 10 months ago (2013-02-12 17:49:36 UTC) #2
lgtm

for future reference, it's helpful when reviewing reverted changes to first
upload the original change, and then upload the fix. that way one can do a
patchset-diff to see what new code went in since the last review.

On 2013/02/12 11:41:17, Paweł Hajdan Jr. wrote:
> I've added a NULL check in ssl_blocking_page.cc, so this should fix the crash,
> but I was wondering how to write a test for this.

i haven't looked at the bug in detail to know what the repro steps are.

> 
> It's not obvious for me how to trigger the crash in a test. If you want to ask
> other people about this, please add them directly to review to decrease
latency.

Powered by Google App Engine
This is Rietveld 408576698