Turn FrameView's paintBehavior into a real global

Source/core/paint/PaintPhase.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 39 matching lines @@
     PaintPhaseCollapsedTableBorders = 9,
     PaintPhaseTextClip = 10,
     PaintPhaseMask = 11,
     PaintPhaseClippingMask = 12,
     PaintPhaseMax = PaintPhaseClippingMask,
     // These values must be kept in sync with DisplayItem::Type and DisplayItem::typeAsDebugString().
 };
 
 enum PaintBehaviorFlags {
     PaintBehaviorNormal = 0,
-    PaintBehaviorSelectionOnly = 1 << 0,
-    PaintBehaviorFlattenCompositingLayers = 1 << 2,
     PaintBehaviorRenderingClipPathAsMask = 1 << 3,
     PaintBehaviorSkipRootBackground = 1 << 4,
     PaintBehaviorRootBackgroundOnly = 1 << 5
 };
 
 typedef unsigned PaintBehavior;
 
+// Those flags are meant as global tree operations. This means
+// that they should be constant for a paint phase.
+// TODO(jchaffraix): We should pass these as a const variable

[leviw_travelin_and_unemployed, 2015/07/07 20:33:16]

GoodFirstBug? :p

+// during paint to ensure they are not modified.
+enum GlobalPaintFlag {
+    GlobalPaintNoFlag = 0,

[leviw_travelin_and_unemployed, 2015/07/07 20:33:16]

What does this mean? How do we expect the system to behave with this value?

[Julien - ping for review, 2015/07/08 01:16:30]

The flags are used to change the way we paint in a deep way, with this value
being the default (ie normal painting). Renamed to GlobalPaintNormalPhase as it
should fit the intent better.

+    // Used when painting selection as part of a drag-image. This
+    // flag bypasses a lot of the painting code. TODO: What is the

[leviw_travelin_and_unemployed, 2015/07/07 20:33:16]

More TODOs without your name.

Why this TODO? You specify the *intent* of the code in the preceding comment. As
for whether it's needed, simply turning it off would give you an idea, no? I
know we do special background handling for this. Are there parts that
specifically confuse you?

[Julien - ping for review, 2015/07/08 01:16:30]

Sure but looking for breakage will not yield to better designs and that's really
what the intent of this TODO was.
My reply to Philip should shed some light here. I removed this comment as the
phase seems needed and it's unclear if there is a better design.

+    // intent of this code? Is it still needed?
+    GlobalPaintSelectionOnly = 1 << 0,

[leviw_travelin_and_unemployed, 2015/07/07 21:39:46]

We should probably rename this to GlobalPaintPaintingDragImage or something to
make it clearer?

[Julien - ping for review, 2015/07/08 01:16:30]

It's actually really about painting only selection so it's not misnamed. It's
also part of drag-image so we could potentially combine them but there is really
nothing drag-image related in the flag itself.

+    // Used when painting a drag-image or printing in order to
+    // ignore the hardware layers and paint the whole tree
+    // into the topmost layer.
+    GlobalPaintFlattenCompositingLayers = 1 << 1
+};
+
+typedef unsigned GlobalPaintFlags;
+
+extern GlobalPaintFlags gGlobalPaintFlags;
+
 } // namespace blink
 
 #endif // PaintPhase_h